Sippy timestamp filter should use Millisecond unix timestamp for proper filtering

[JoelSpeed]

The sippy API expects a millisecond timestamp to ensure proper filtering. Tested locally I can see that with this fix it was showing around 30 runs in the past two weeks for the AWS dual stack job which tallies with what sippy reports

CC @everettraven

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci]

Hello @JoelSpeed! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: d72de54d-2ab8-4cf0-b85c-428f164a8e89

📥 Commits

Reviewing files that changed from the base of the PR and between 2dd36ba and 2796bf4.

📒 Files selected for processing (1)

• tools/codegen/pkg/sippy/json_types.go

---

📝 Walkthrough

Walkthrough

Updated BuildSippyJobRunsForJobURL to send the timestamp >= filter to the Sippy API in Unix milliseconds instead of Unix seconds.

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and accurately summarizes the main change: switching the Sippy timestamp filter to milliseconds.
Description check	✅ Passed	The description matches the change and explains the millisecond timestamp fix with supporting testing context.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PR only changes a Sippy timestamp filter in implementation code; no Ginkgo test titles were added or modified.
Test Structure And Quality	✅ Passed	Only tools/codegen/pkg/sippy/json_types.go changed; no Ginkgo tests were added or modified, so this test-quality check is not applicable.
Microshift Test Compatibility	✅ Passed	Only a Sippy URL helper changed from Unix to UnixMilli; no new Ginkgo e2e tests or MicroShift-unsupported APIs were added.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	No new Ginkgo e2e tests were added; the PR only changes a Sippy URL helper, so the SNO compatibility check is not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	PR only changes a Sippy URL timestamp unit from seconds to milliseconds; no manifests, controllers, replicas, affinities, or node selectors were added.
Ote Binary Stdout Contract	✅ Passed	The PR only changes a Sippy URL builder in a library file; it adds no main/suite setup or stdout writes.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	Only tools/codegen/pkg/sippy/json_types.go changed; no new/modified Ginkgo e2e tests or network-sensitive code were added.
No-Weak-Crypto	✅ Passed	The PR only changes a Sippy timestamp unit from Unix to UnixMilli; no weak crypto, custom crypto, or secret comparison code is added.
Container-Privileges	✅ Passed	PASS: PR only changes tools/codegen/pkg/sippy/json_types.go; no container/K8s manifests or privilege settings were modified.
No-Sensitive-Data-In-Logs	✅ Passed	The only code change is Unix()→UnixMilli() in a Sippy URL builder; no log statements or sensitive-data handling were added.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.12.2)

Error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented
The command is terminated due to an error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented

---

_{Comment @coderabbitai help to get the list of available commands.}

[JoelSpeed]

/verified by @JoelSpeed
/approve

[openshift-ci-robot]

@JoelSpeed: This PR has been marked as verified by @JoelSpeed.

Details

In response to this:

/verified by @JoelSpeed
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[everettraven]

/lgtm

[openshift-merge-bot]

Pipeline controller notification

No second-stage tests were triggered for this PR.

This can happen when:

• The changed files don't match any pipeline_run_if_changed patterns
• All files match pipeline_skip_if_only_changed patterns
• No pipeline-controlled jobs are defined for the master branch

Use /test ? to see all available tests.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: everettraven, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [JoelSpeed,everettraven]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@JoelSpeed: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[JoelSpeed]

/label acknowledge-critical-fixes-only

Tiny tooling change, not relevant to the payload