Skip to content

Comments

Bug 1887392: operatorconfig: add cache TTL to delegated authn/z#832

Closed
stlaz wants to merge 1 commit intoopenshift:masterfrom
stlaz:operatorconfig_authnz_caching
Closed

Bug 1887392: operatorconfig: add cache TTL to delegated authn/z#832
stlaz wants to merge 1 commit intoopenshift:masterfrom
stlaz:operatorconfig_authnz_caching

Conversation

@stlaz
Copy link
Contributor

@stlaz stlaz commented Jan 5, 2021

This is to allow caching TokenReview/SAR responses in the operators to reduce requests to the API server due to /metrics requests

/assign @sttts

@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Jan 5, 2021
@openshift-ci-robot
Copy link

@stlaz: This pull request references Bugzilla bug 1887392, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

Bug 1887392: operatorconfig: add cache TTL to delegated authn/z

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 5, 2021
@stlaz stlaz force-pushed the operatorconfig_authnz_caching branch from 67b5bf9 to a9dfda0 Compare January 5, 2021 13:40
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: stlaz
To complete the pull request process, please assign sttts after the PR has been reviewed.
You can assign the PR to them by writing /assign @sttts in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@stlaz
Copy link
Contributor Author

stlaz commented Jan 6, 2021

/close
we went with hardcoding the values instead

@openshift-ci-robot
Copy link

@stlaz: Closed this PR.

Details

In response to this:

/close
we went with hardcoding the values instead

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

@stlaz: This pull request references Bugzilla bug 1887392. The bug has been updated to no longer refer to the pull request using the external bug tracker.

Details

In response to this:

Bug 1887392: operatorconfig: add cache TTL to delegated authn/z

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants