Skip to content

Fix agentic SDLC check: resolve @ includes, switch to informing mode - #790

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:masterfrom
tnierman:fix-agentic-sdlc-includes
Jul 8, 2026
Merged

Fix agentic SDLC check: resolve @ includes, switch to informing mode#790
openshift-merge-bot[bot] merged 1 commit into
openshift:masterfrom
tnierman:fix-agentic-sdlc-includes

Conversation

@tnierman

@tnierman tnierman commented Jul 7, 2026

Copy link
Copy Markdown
Member

Summary

Two fixes for the agentic SDLC conformance check pipeline added in #788:

  1. Resolve CLAUDE.md @ includes — repos using @AGENTS.md (or similar Claude Code include directives) had content checks fail because the script only read CLAUDE.md itself. Now resolves one level of @ references, deduplicates with sort -u, and checks the combined content.

  2. Add onError: continue to both check tasks so the pipeline always passes at the PipelineRun level. Non-conformance is still visible in the individual task status (red task in Konflux UI) but the overall GitHub check reports success.

What changed

Line Change
check-file-existence task Added onError: continue
check-content-validation task Added onError: continue
CLAUDE.md content resolution Resolves @ references one level deep before checking for required sections

Testing

Validated locally against openshift/deadmanssnitch-operator (which uses @AGENTS.md as its CLAUDE.md):

  • Before fix: content checks fail (only sees @AGENTS.md text)
  • After fix: resolves to CLAUDE.md + AGENTS.md, finds all required sections, passes 17/18 (1 advisory warning)

🤖 Generated with Claude Code

@coderabbitai

coderabbitai Bot commented Jul 7, 2026

Copy link
Copy Markdown

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • boilerplate/openshift/golang-osd-operator/agentic-sdlc-check-pull-request.yaml.tmpl is excluded by !boilerplate/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: a5543620-1771-4a02-884c-80cbcc373532

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from clcollins and xiaoyu74 July 7, 2026 20:54
@AlexSmithGH

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 8, 2026
Two fixes for the agentic SDLC conformance check pipeline:

1. Resolve CLAUDE.md @ includes: repos using `@AGENTS.md` (or similar
   include directives) had content checks fail because the script only
   read CLAUDE.md itself. Now resolves one level of @ references and
   checks the combined content. Deduplicates with sort -u.

2. Add onError: continue to both check tasks so the pipeline always
   passes at the PipelineRun level. Non-conformance is still visible
   in the individual task status (red task in Konflux UI) but the
   overall check reports success. This avoids noisy red X signals on
   repos that are still being onboarded.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@tnierman
tnierman force-pushed the fix-agentic-sdlc-includes branch from c7e8a5d to 1000b99 Compare July 8, 2026 22:46
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2026
@clcollins

Copy link
Copy Markdown
Member

/lgtm
/approve

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2026
@openshift-ci

openshift-ci Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlexSmithGH, clcollins, tnierman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [AlexSmithGH,clcollins]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
openshift-merge-bot Bot merged commit fda17da into openshift:master Jul 8, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants