CORS-4534: UPSTREAM: <carry>: Enable MachineTaintPropagation feature gate by tthvo · Pull Request #303 · openshift/cluster-api

tthvo · 2026-07-06T23:42:37Z

Description

Enable MachineTaintPropagation feature gate on CAPI controllers. This is a requirement for edge compute pool (AWS local and wavelength zones).

See openshift/installer#10625

Summary by CodeRabbit

Improvements
- Machine taint propagation is now included in the controller’s enabled feature set by default.
- Other feature gate settings and defaults remain unchanged.
Configuration
- The default behavior can still be overridden using the existing environment-based configuration.

coderabbitai · 2026-07-06T23:42:59Z

Walkthrough

The controller-manager feature-gates argument is extended in two manifest locations to include MachineTaintPropagation with a true default, while the existing feature gates remain unchanged.

Changes

Feature gate patch update

Layer / File(s)	Summary
Feature gate argument update `openshift/patches/enable-metadata-syncing.yaml`, `openshift/capi-operator-manifests/default/manifests.yaml`	Both manifest entries add `MachineTaintPropagation=${EXP_MACHINE_TAINT_PROPAGATION:=true}` to the existing `--feature-gates` value.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Related PRs: None identified.

Suggested labels: None

Suggested reviewers: None

🐰 A tiny gate swings open wide,
MachineTaintPropagation steps inside,
One line of YAML, true by default,
No fanfare needed, no big exalt—
Just a small hop in the rabbit's stride.

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The commit only changes two YAML manifests; no test files or Ginkgo titles were added or modified.
Test Structure And Quality	✅ Passed	No Ginkgo test code was changed; the PR only updates YAML manifests, so the test-quality check is not applicable.
Microshift Test Compatibility	✅ Passed	Only manifest feature-gate args changed; no new or modified Ginkgo tests were added, so no MicroShift-incompatible test code to flag.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	No Ginkgo e2e tests were added; the PR only updates manifest feature-gate args, so SNO test compatibility is not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	Only the controller `--feature-gates` string changed; no replica, nodeSelector, anti-affinity, topology spread, or arbiter/control-plane targeting was introduced.
Ote Binary Stdout Contract	✅ Passed	Only YAML manifests were changed; no main/init/TestMain/suite-setup code or stdout writes were introduced.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PR only changes manifest feature-gate args in YAML; no new Ginkgo tests or networking code were added, so this check is not applicable.
No-Weak-Crypto	✅ Passed	Changed YAML only extends feature-gates with MachineTaintPropagation; no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB or custom crypto found.
Container-Privileges	✅ Passed	Only feature-gates were changed; the manifest securityContext remains restrictive (privileged:false, allowPrivilegeEscalation:false, drop ALL, runAsNonRoot:true) and no host namespace flags were ad...
No-Sensitive-Data-In-Logs	✅ Passed	Diff only extends feature-gates in two deployment manifests; no log statements or sensitive data fields were added.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: enabling the MachineTaintPropagation feature gate.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands.}

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@openshift/patches/enable-metadata-syncing.yaml`:
- Line 15: Restore the default for MachineSetPreflightChecks in the
feature-gates string used by enable-metadata-syncing.yaml; the change should
only introduce MachineTaintPropagation and must not alter
EXP_MACHINE_SET_PREFLIGHT_CHECKS. Update the existing --feature-gates entry so
MachineSetPreflightChecks keeps its prior default in the controller-manager
configuration, using the same feature-gates list and symbols already present.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 96d3d4f7-7c97-4188-b147-071dc2d45fc0

📥 Commits

Reviewing files that changed from the base of the PR and between 4917d86 and dad5b41.

📒 Files selected for processing (1)

openshift/patches/enable-metadata-syncing.yaml

tthvo · 2026-07-07T02:16:38Z

/test e2e-hypershift

tthvo · 2026-07-07T02:16:50Z

/cc @nrb

tthvo · 2026-07-07T03:16:23Z

/retest

nrb · 2026-07-07T15:45:02Z

Looks like hypershift has failed 3/3 runs; 2 of them had a bunch of missing condition: wanted <condition>=True, did not find condition of this type, though I don't believe these conditions are for CAPA itself. Based on the history, the job was passing prior to this PR. Hopefully we're not hitting some sort of conflict with Hypershift, propagation, and/or taints.

First run with such failures

    eventually.go:228:  - missing condition: wanted ReconciliationSucceeded=True, did not find condition of this type
    eventually.go:228:  - missing condition: wanted ValidReleaseImage=True, did not find condition of this type
    eventually.go:228:  - missing condition: wanted IgnitionEndpointAvailable=True, did not find condition of this type
    eventually.go:228:  - missing condition: wanted EtcdAvailable=True, did not find condition of this type
    eventually.go:228:  - missing condition: wanted ValidHostedControlPlaneConfiguration=True, did not find condition of this type
    eventually.go:228:  - missing condition: wanted Degraded=False, did not find condition of this type
    eventually.go:228:  - missing condition: wanted ClusterVersionProgressing=False, did not find condition of this type
    eventually.go:228:  - missing condition: wanted ValidOIDCConfiguration=True, did not find condition of this type
    eventually.go:228:  - missing condition: wanted AWSDefaultSecurityGroupCreated=True, did not find condition of this type
    eventually.go:228:  - missing condition: wanted KubeAPIServerAvailable=True, did not find condition of this type
    eventually.go:228:  - missing condition: wanted SupportedHostedCluster=True, did not find condition of this type
    eventually.go:228:  - missing condition: wanted PlatformCredentialsFound=True, did not find condition of this type
    hypershift_framework.go:349: skipping postTeardown()
    hypershift_framework.go:327: skipping teardown, already called

Second run with such failures

    eventually.go:228:  - missing condition: wanted IgnitionEndpointAvailable=True, did not find condition of this type
    eventually.go:228:  - missing condition: wanted EtcdAvailable=True, did not find condition of this type
    eventually.go:228:  - missing condition: wanted ValidConfiguration=True, did not find condition of this type
    eventually.go:228:  - missing condition: wanted SupportedHostedCluster=True, did not find condition of this type
    eventually.go:228:  - missing condition: wanted ReconciliationSucceeded=True, did not find condition of this type
    eventually.go:228:  - missing condition: wanted ValidOIDCConfiguration=True, did not find condition of this type
    eventually.go:228:  - missing condition: wanted ValidAWSKMSConfig=Unknown, did not find condition of this type
    eventually.go:228:  - missing condition: wanted Available=True, did not find condition of this type
    eventually.go:228:  - missing condition: wanted InfrastructureReady=True, did not find condition of this type
    eventually.go:228:  - missing condition: wanted ValidReleaseInfo=True, did not find condition of this type
    eventually.go:228:  - missing condition: wanted ClusterVersionAvailable=True, did not find condition of this type
    eventually.go:228:  - missing condition: wanted Progressing=False, did not find condition of this type
    hypershift_framework.go:349: skipping postTeardown()
    hypershift_framework.go:327: skipping teardown, already called

tthvo · 2026-07-07T16:00:09Z

/test e2e-hypershift

damdo · 2026-07-08T13:50:36Z

/test e2e-hypershift

damdo

/approve
/lgtm

openshift-ci · 2026-07-08T14:58:58Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damdo, tthvo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [damdo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tthvo · 2026-07-08T17:23:19Z

/verified by @tthvo

openshift-ci-robot · 2026-07-08T17:23:31Z

@tthvo: This PR has been marked as verified by @tthvo.

Details

In response to this:

/verified by @tthvo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

tthvo · 2026-07-08T17:26:48Z

/retitle CORS-4534: UPSTREAM: : Enable MachineTaintPropagation feature gate

openshift-ci-robot · 2026-07-08T17:26:56Z

@tthvo: This pull request references CORS-4534 which is a valid jira issue.

Details

In response to this:

Description

Enable MachineTaintPropagation feature gate on CAPI controllers. This is a requirement for edge compute pool (AWS local and wavelength zones).

See openshift/installer#10625

Summary by CodeRabbit

Improvements

Machine taint propagation is now included in the controller’s enabled feature set by default.

Other feature gate settings and defaults remain unchanged.

Configuration

The default behavior can still be overridden using the existing environment-based configuration.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-merge-bot · 2026-07-08T19:19:27Z

/retest-required

Remaining retests: 0 against base HEAD af15b10 and 2 for PR HEAD b344428 in total

tthvo · 2026-07-08T20:51:31Z

/test e2e-vsphere-staticip-ipam-ovn

tthvo · 2026-07-09T00:02:01Z

/test e2e-vsphere-staticip-ipam-ovn

tthvo · 2026-07-09T02:51:28Z

/retest-required

tthvo · 2026-07-09T05:33:23Z

/retest-required

tthvo · 2026-07-09T08:27:45Z

/retest-required

openshift-ci · 2026-07-09T11:10:37Z

@tthvo: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci Bot requested review from damdo and racheljpg July 6, 2026 23:43

coderabbitai Bot reviewed Jul 6, 2026

View reviewed changes

Comment thread openshift/patches/enable-metadata-syncing.yaml

UPSTREAM: <carry>: Enable MachineTaintPropagation feature gate

b344428

tthvo force-pushed the machine-taint-fg branch from dad5b41 to b344428 Compare July 6, 2026 23:46

openshift-ci Bot requested a review from nrb July 7, 2026 02:16

tthvo mentioned this pull request Jul 7, 2026

CORS-4507: aws: support edge machine pool management with ClusterAPI openshift/installer#10625

Open

damdo reviewed Jul 8, 2026

View reviewed changes

openshift-ci Bot assigned damdo Jul 8, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2026

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2026

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jul 8, 2026

openshift-ci Bot changed the title ~~UPSTREAM: <carry>: Enable MachineTaintPropagation feature gate~~ CORS-4534: UPSTREAM: <carry>: Enable MachineTaintPropagation feature gate Jul 8, 2026

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 8, 2026

openshift-merge-bot Bot merged commit 75dfb8c into openshift:main Jul 9, 2026
20 checks passed

Uh oh!

Conversation

tthvo commented Jul 6, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jul 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

tthvo commented Jul 7, 2026

Uh oh!

tthvo commented Jul 7, 2026

Uh oh!

tthvo commented Jul 7, 2026

Uh oh!

nrb commented Jul 7, 2026

Uh oh!

tthvo commented Jul 7, 2026

Uh oh!

damdo commented Jul 8, 2026

Uh oh!

damdo left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci Bot commented Jul 8, 2026

Uh oh!

tthvo commented Jul 8, 2026

Uh oh!

openshift-ci-robot commented Jul 8, 2026

Uh oh!

tthvo commented Jul 8, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Jul 8, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Summary by CodeRabbit

Uh oh!

openshift-merge-bot Bot commented Jul 8, 2026

Uh oh!

tthvo commented Jul 8, 2026

Uh oh!

tthvo commented Jul 9, 2026

Uh oh!

tthvo commented Jul 9, 2026

Uh oh!

tthvo commented Jul 9, 2026

Uh oh!

tthvo commented Jul 9, 2026

Uh oh!

openshift-ci Bot commented Jul 9, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

tthvo commented Jul 6, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jul 6, 2026 •

edited

Loading

tthvo commented Jul 8, 2026 •

edited by openshift-ci Bot

Loading

openshift-ci-robot commented Jul 8, 2026 •

edited by openshift-ci Bot

Loading