Add .ansible-lint - #272
Conversation
openshift-ci
Bot
added
the
approved
|
recheck |
|
/retest |
|
@beeankha: changing LGTM is restricted to collaborators DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/lgtm |
|
/retest |
1 similar comment
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abikouo, alinabuzachis, beeankha, gravesm The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
1f1251a to
bc93fe7
Compare
|
/retest |
| --- | ||
| profile: production | ||
| exclude_paths: | ||
| - tests/unit |
There was a problem hiding this comment.
The reason the linters are failing is because of some ignore lines in the sanity config. Specifically, things like
The k8s collection has the exact same problem. In fact, the reason this collection needs that ignore is because of the arg spec being imported from k8s.core. The way we solved it in k8s is by adding
tests/sanity here. I don't know if that's necessarily the best solution, but it does make the linters pass, and we are currently doing that with k8s.core.
There was a problem hiding this comment.
@gravesm Can you please apply lgtm if the changes are good for you? Thank you.
|
@alinabuzachis: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
@alinabuzachis: you cannot LGTM your own PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Fair enough! |
|
/lgtm |
5 participants
As per https://issues.redhat.com/browse/ACA-2243, add .ansible-lint file.