Skip to content

Fixed the links in the events card - #2830

Merged
openshift-merge-robot merged 1 commit into
openshift:masterfrom
afreen23:events-link-fix
Sep 26, 2019
Merged

Fixed the links in the events card#2830
openshift-merge-robot merged 1 commit into
openshift:masterfrom
afreen23:events-link-fix

Conversation

@afreen23

@afreen23 afreen23 commented Sep 25, 2019 •
edited
Loading

Copy link
Copy Markdown
  • link for runtime CRDs were not present

Before

err2

After

err

cc @rawagner

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 25, 2019
@openshift-ci-robot openshift-ci-robot added component/core Related to console core functionality component/dashboard Related to dashboard labels Sep 25, 2019
@afreen23
afreen23 changed the base branch from master to master-4.3 September 25, 2019 11:17
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 25, 2019
@afreen23
afreen23 changed the base branch from master-4.3 to master September 25, 2019 11:20
@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 25, 2019
@openshift-ci-robot openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. component/ceph Related to ceph-storage-plugin component/dev-console Related to dev-console component/kubevirt Related to kubevirt-plugin component/metal3 Related to metal3-plugin component/monitoring Related to monitoring component/noobaa Related to noobaa-storage-plugin component/olm Related to OLM component/sdk Related to console-plugin-sdk component/shared Related to console-shared and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 25, 2019
@afreen23
afreen23 changed the base branch from master to master-4.3 September 25, 2019 11:24
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 25, 2019
Afreen Rahman
Fixed the links in the event card
73a8431 
- the runtime crds link were not present

Signed-off-by: Afreen Rahman <afrahman@redhat.com>
@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 25, 2019
@afreen23

afreen23 commented Sep 25, 2019

Copy link
Copy Markdown
Author

By mistake sent it to the master, fixed now.

@spadgett
spadgett changed the base branch from master-4.3 to master September 25, 2019 20:05
spadgett
spadgett approved these changes Sep 25, 2019
View reviewed changes

@spadgett spadgett left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 25, 2019
@spadgett spadgett added this to the v4.3 milestone Sep 25, 2019
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 25, 2019
@spadgett spadgett removed approved Indicates a PR has been approved by an approver from all required OWNERS files. component/ceph Related to ceph-storage-plugin component/core Related to console core functionality component/dev-console Related to dev-console component/kubevirt Related to kubevirt-plugin component/metal3 Related to metal3-plugin component/monitoring Related to monitoring component/noobaa Related to noobaa-storage-plugin component/olm Related to OLM component/sdk Related to console-plugin-sdk component/shared Related to console-shared labels Sep 25, 2019
@spadgett

spadgett commented Sep 26, 2019

Copy link
Copy Markdown
Member

/approve

@openshift-ci-robot

openshift-ci-robot commented Sep 26, 2019

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afreen23, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 26, 2019
@openshift-merge-robot
openshift-merge-robot merged commit 6b91cba into openshift:master Sep 26, 2019
@rawagner rawagner mentioned this pull request Nov 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spadgett spadgett spadgett approved these changes
@rawagner rawagner Awaiting requested review from rawagner

Assignees

@spadgett spadgett

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dashboard Related to dashboard lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

v4.3

Development

Successfully merging this pull request may close these issues.

4 participants

@afreen23 @spadgett @openshift-ci-robot @openshift-merge-robot