Skip to content

Bug 1754991: Fix links in event item for CRD - #3351

Merged
openshift-merge-robot merged 1 commit into
openshift:masterfrom
rawagner:fix_crd_links
Nov 12, 2019
Merged

Bug 1754991: Fix links in event item for CRD#3351
openshift-merge-robot merged 1 commit into
openshift:masterfrom
rawagner:fix_crd_links

Conversation

@rawagner

@rawagner rawagner commented Nov 12, 2019

Copy link
Copy Markdown
Contributor

same fix as #2830 but this time for Activity card

@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@rawagner: This pull request references Bugzilla bug 1754991, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Bug 1754991: Fix links in event item for CRD

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. component/dashboard Related to dashboard component/shared Related to console-shared labels Nov 12, 2019
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@rawagner: This pull request references Bugzilla bug 1754991, which is valid.

Details

In response to this:

Bug 1754991: Fix links in event item for CRD

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett

Copy link
Copy Markdown
Member

Does this fix need to be backported to 4.2?

@spadgett spadgett left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 12, 2019
@spadgett spadgett added this to the v4.3 milestone Nov 12, 2019
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rawagner, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot
openshift-merge-robot merged commit 8a44a1f into openshift:master Nov 12, 2019
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@rawagner: All pull requests linked via external trackers have merged. Bugzilla bug 1754991 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1754991: Fix links in event item for CRD

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rawagner

Copy link
Copy Markdown
Contributor Author

Does this fix need to be backported to 4.2?

this one is for Activity card which isnt in 4.2, but we could backport #2830

@spadgett

Copy link
Copy Markdown
Member

I'd think we'd want to, but we'll need a Bugzilla to backport. We can probably use Bug 1754991.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/dashboard Related to dashboard component/shared Related to console-shared lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants