e2e-pool: Better wait for controllers to be ready#2087
Conversation
It turns out we weren't actually disabling managed DNS for e2e-pool -- see openshift/release#42172. However, attempting to do so revealed a timing problem which was being papered over: We were using `oc wait` to wait for the controllers to become ready, but hive-operator hadn't yet gotten a chance to create those deployments. (When we were enabling managed DNS, that process took some time *and* waited for those deployments, so we never noticed.) With this commit, after waiting for the hive-operator deployment itself to become Available, we then wait for HiveConfig to report Ready, indicating that the operator has created the deployments.
|
/assign @dlom |
openshift-ci
Bot
added
the
approved
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 2uasimojo, dlom The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@2uasimojo: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/cherry-pick mce-2.3 |
|
@2uasimojo: new pull request created: #2089 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
5 participants
It turns out we weren't actually disabling managed DNS for e2e-pool -- see openshift/release#42172. However, attempting to do so revealed a timing problem which was being papered over: We were using
oc waitto wait for the controllers to become ready, but hive-operator hadn't yet gotten a chance to create those deployments. (When we were enabling managed DNS, that process took some time and waited for those deployments, so we never noticed.)With this commit, after waiting for the hive-operator deployment itself to become Available, we then wait for HiveConfig to report Ready, indicating that the operator has created the deployments.