Skip to content

[mce-2.3] e2e-pool: Better wait for controllers to be ready#2089

Merged
2uasimojo merged 1 commit into
openshift:mce-2.3from
openshift-cherrypick-robot:cherry-pick-2087-to-mce-2.3
Aug 10, 2023
Merged

[mce-2.3] e2e-pool: Better wait for controllers to be ready#2089
2uasimojo merged 1 commit into
openshift:mce-2.3from
openshift-cherrypick-robot:cherry-pick-2087-to-mce-2.3

Conversation

@openshift-cherrypick-robot
Copy link
Copy Markdown

This is an automated cherry-pick of #2087

/assign 2uasimojo

It turns out we weren't actually disabling managed DNS for e2e-pool --
see openshift/release#42172. However, attempting
to do so revealed a timing problem which was being papered over: We were
using `oc wait` to wait for the controllers to become ready, but
hive-operator hadn't yet gotten a chance to create those deployments.
(When we were enabling managed DNS, that process took some time *and*
waited for those deployments, so we never noticed.)

With this commit, after waiting for the hive-operator deployment itself
to become Available, we then wait for HiveConfig to report Ready,
indicating that the operator has created the deployments.
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 10, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot
Once this PR has been reviewed and has the lgtm label, please assign 2uasimojo for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@2uasimojo
Copy link
Copy Markdown
Member

Just gonna mash this in. We'll find out via openshift/release#42172 if it didn't work.

@2uasimojo
Copy link
Copy Markdown
Member

/cherry-pick mce-2.2

@openshift-cherrypick-robot
Copy link
Copy Markdown
Author

@2uasimojo: new pull request created: #2090

Details

In response to this:

/cherry-pick mce-2.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants