[mce-2.2] e2e-pool: Better wait for controllers to be ready#2090
Merged
2uasimojo merged 1 commit intoAug 10, 2023
Merged
Conversation
It turns out we weren't actually disabling managed DNS for e2e-pool -- see openshift/release#42172. However, attempting to do so revealed a timing problem which was being papered over: We were using `oc wait` to wait for the controllers to become ready, but hive-operator hadn't yet gotten a chance to create those deployments. (When we were enabling managed DNS, that process took some time *and* waited for those deployments, so we never noticed.) With this commit, after waiting for the hive-operator deployment itself to become Available, we then wait for HiveConfig to report Ready, indicating that the operator has created the deployments.
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Member
|
Just gonna mash this in. We'll find out via openshift/release#42172 if it didn't work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #2089
/assign 2uasimojo