Skip to content

[enterprise-4.15] TELCODOCS-1976: Adding content for improved SR-IOV Network Operator node draining#79757

Merged
snarayan-redhat merged 1 commit intoopenshift:enterprise-4.15from
amolnar-gh:TELCODOCS-1976-4.15
Aug 19, 2024
Merged

[enterprise-4.15] TELCODOCS-1976: Adding content for improved SR-IOV Network Operator node draining#79757
snarayan-redhat merged 1 commit intoopenshift:enterprise-4.15from
amolnar-gh:TELCODOCS-1976-4.15

Conversation

@amolnar-gh
Copy link
Contributor

@amolnar-gh amolnar-gh commented Jul 31, 2024

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 31, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 31, 2024

@amolnar-rh: This pull request references TELCODOCS-1976 which is a valid jira issue.

Details

In response to this:

Version(s): 4.15

Issue: https://issues.redhat.com/browse/CNF-13765

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 31, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 31, 2024

@amolnar-rh: This pull request references TELCODOCS-1976 which is a valid jira issue.

Details

In response to this:

Version(s): 4.15

Issue: https://issues.redhat.com/browse/CNF-13765

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
Cherrypicked from the original main and RN PRs:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jul 31, 2024

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 1, 2024

@amolnar-rh: This pull request references TELCODOCS-1976 which is a valid jira issue.

Details

In response to this:

Version(s): 4.15

Issue: https://issues.redhat.com/browse/CNF-13765

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
Cherrypicked from the original main and RN PRs:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 1, 2024

@amolnar-rh: This pull request references TELCODOCS-1976 which is a valid jira issue.

Details

In response to this:

Version(s): 4.15

Issue: https://issues.redhat.com/browse/TELCODOCS-1976

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
Cherrypicked from the original main and RN PRs:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 1, 2024

@amolnar-rh: This pull request references TELCODOCS-1976 which is a valid jira issue.

Details

In response to this:

Version(s): 4.15

Issue: https://issues.redhat.com/browse/TELCODOCS-1976

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
Cherrypicked from the original main and RN PRs:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ealcaniz
Copy link

ealcaniz commented Aug 6, 2024

LGTM

@SchSeba
Copy link
Contributor

SchSeba commented Aug 8, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 8, 2024
@evgenLevin
Copy link

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Aug 14, 2024

@evgenLevin: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@amolnar-gh
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Aug 15, 2024
@lahinson lahinson added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Aug 15, 2024
Copy link
Contributor

@lahinson lahinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I applied the same changes here as I did to #79809.

= Configuring parallel node draining during SR-IOV network policy updates

By default, the SR-IOV Network Operator drains workloads from a node before every policy change.
The Operator performs this action, one node at a time, to ensure that no workloads are affected by the reconfiguration.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The Operator performs this action, one node at a time, to ensure that no workloads are affected by the reconfiguration.
The Operator completes this action, one node at a time, to ensure that no workloads are affected by the reconfiguration.


[NOTE]
====
A node can only belong to one SR-IOV network pool configuration. If a node is not part of a pool, it is added to a virtual, default, pool that is configured to drain one node at a time only.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
A node can only belong to one SR-IOV network pool configuration. If a node is not part of a pool, it is added to a virtual, default, pool that is configured to drain one node at a time only.
A node can belong to only one SR-IOV network pool configuration. If a node is not part of a pool, it is added to a virtual, default pool that is configured to drain one node at a time only.

* Install the OpenShift CLI (`oc`).
* Log in as a user with `cluster-admin` privileges.
* Install the SR-IOV Network Operator.
* Nodes have hardware that support SR-IOV.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Nodes have hardware that support SR-IOV.
* Ensure that nodes have hardware that supports SR-IOV.

----
<1> Specify the name of the `SriovNetworkPoolConfig` object.
<2> Specify namespace where the SR-IOV Network Operator is installed.
<3> Specify an integer number, or percentage value, for nodes that can be unavailable in the pool during an update. For example, if you have 10 nodes and you set the maximum unavailable to 2, then only 2 nodes can be drained in parallel at any time, leaving 8 nodes for handling workloads.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<3> Specify an integer number, or percentage value, for nodes that can be unavailable in the pool during an update. For example, if you have 10 nodes and you set the maximum unavailable to 2, then only 2 nodes can be drained in parallel at any time, leaving 8 nodes for handling workloads.
<3> Specify an integer number or percentage value for nodes that can be unavailable in the pool during an update. For example, if you have 10 nodes and you set the maximum unavailable value to 2, then only 2 nodes can be drained in parallel at any time, leaving 8 nodes for handling workloads.

----
<1> In this example, `pool-1` contains all the nodes with the `worker` role.

To demonstrate the node draining process using the example scenario from the above procedure, complete the following steps:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To demonstrate the node draining process using the example scenario from the above procedure, complete the following steps:
To demonstrate the node draining process by using the example scenario from the previous procedure, complete the following steps:

Should this be formatted as a bulleted item like the bulleted item above it on line 124?


With this update, you can configure the SR-IOV Network Operator to drain nodes in parallel during network policy updates. The option to drain nodes in parallel enables faster rollouts of SR-IOV network configurations. You can use the `SriovNetworkPoolConfig` custom resource to configure parallel node draining and define the maximum number of nodes in the pool that the Operator can drain in parallel.

For further information, see xref:../networking/hardware_networks/configuring-sriov-device.adoc#configure-sr-iov-operator-parallel-nodes_configuring-sriov-device[Configuring parallel node draining during SR-IOV network policy updates].
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
For further information, see xref:../networking/hardware_networks/configuring-sriov-device.adoc#configure-sr-iov-operator-parallel-nodes_configuring-sriov-device[Configuring parallel node draining during SR-IOV network policy updates].
For more information, see xref:../networking/hardware_networks/configuring-sriov-device.adoc#configure-sr-iov-operator-parallel-nodes_configuring-sriov-device[Configuring parallel node draining during SR-IOV network policy updates].

@lahinson lahinson added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Aug 15, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 16, 2024

@amolnar-rh: This pull request references TELCODOCS-1976 which is a valid jira issue.

Details

In response to this:

Version(s): 4.15

Issue: https://issues.redhat.com/browse/TELCODOCS-1976

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
Cherrypicked from the original main and RN PRs:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@amolnar-gh amolnar-gh force-pushed the TELCODOCS-1976-4.15 branch from c705018 to 70b7790 Compare August 19, 2024 09:26
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 19, 2024
@openshift-ci
Copy link

openshift-ci bot commented Aug 19, 2024

New changes are detected. LGTM label has been removed.

@amolnar-gh amolnar-gh changed the title (WIP) [enterprise-4.15] TELCODOCS-1976: Adding content for improved SR-IOV Network Operator node draining [enterprise-4.15] TELCODOCS-1976: Adding content for improved SR-IOV Network Operator node draining Aug 19, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 19, 2024
@amolnar-gh
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Aug 19, 2024
@amolnar-gh amolnar-gh force-pushed the TELCODOCS-1976-4.15 branch from 70b7790 to 7483cef Compare August 19, 2024 09:39
@openshift-ci
Copy link

openshift-ci bot commented Aug 19, 2024

@amolnar-rh: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@snarayan-redhat snarayan-redhat added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Aug 19, 2024
@snarayan-redhat snarayan-redhat merged commit 906c548 into openshift:enterprise-4.15 Aug 19, 2024
@snarayan-redhat snarayan-redhat removed the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants