Skip to content

[enterprise-4.14] TELCODOCS-1958: Adding content for improved SR-IOV Network Operator node draining#79809

Merged
stevsmit merged 1 commit intoopenshift:enterprise-4.14from
amolnar-gh:TELCODOCS-1958-4.14
Aug 19, 2024
Merged

[enterprise-4.14] TELCODOCS-1958: Adding content for improved SR-IOV Network Operator node draining#79809
stevsmit merged 1 commit intoopenshift:enterprise-4.14from
amolnar-gh:TELCODOCS-1958-4.14

Conversation

@amolnar-gh
Copy link
Contributor

@amolnar-gh amolnar-gh commented Aug 1, 2024 •
edited
Loading

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 1, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 1, 2024 •
edited by openshift-ci bot
Loading

@amolnar-rh: This pull request references TELCODOCS-1958 which is a valid jira issue.

Details

In response to this:

Version(s): 4.14

Issue: https://issues.redhat.com/browse/TELCODOCS-1958

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@amolnar-gh amolnar-gh changed the title TELCODOCS-1958: Adding content for improved SR-IOV Network Operator node draining (WIP) [enterprise-4.14] TELCODOCS-1958: Adding content for improved SR-IOV Network Operator node draining Aug 1, 2024
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Aug 1, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 1, 2024 •
edited by openshift-ci bot
Loading

@amolnar-rh: This pull request references TELCODOCS-1958 which is a valid jira issue.

Details

In response to this:

Version(s): 4.14

Issue: https://issues.redhat.com/browse/TELCODOCS-1958

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
Cherrypicked from the original main and RN PRs:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Aug 1, 2024 •
edited
Loading

🤖 Mon Aug 19 14:03:07 - Prow CI generated the docs preview:

https://79809--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/hardware_networks/configuring-sriov-device.html
https://79809--ocpdocs-pr.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-14-release-notes.html

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 1, 2024 •
edited by openshift-ci bot
Loading

@amolnar-rh: This pull request references TELCODOCS-1958 which is a valid jira issue.

Details

In response to this:

Version(s): 4.14

Issue: https://issues.redhat.com/browse/TELCODOCS-1958

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
Cherrypicked from the original main and RN PRs:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 1, 2024 •
edited by openshift-ci bot
Loading

@amolnar-rh: This pull request references TELCODOCS-1958 which is a valid jira issue.

Details

In response to this:

Version(s): 4.14

Issue: https://issues.redhat.com/browse/TELCODOCS-1958

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
Cherrypicked from the original main and RN PRs:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@amolnar-gh amolnar-gh force-pushed the TELCODOCS-1958-4.14 branch 2 times, most recently from 191c66e to f4f9590 Compare August 1, 2024 10:55
@ealcaniz
Copy link

ealcaniz commented Aug 6, 2024

LGTM

@SchSeba
Copy link
Contributor

SchSeba commented Aug 8, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 8, 2024
@evgenLevin
Copy link

evgenLevin commented Aug 14, 2024

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Aug 14, 2024

@evgenLevin: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@amolnar-gh
Copy link
Contributor Author

amolnar-gh commented Aug 15, 2024

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Aug 15, 2024
@lahinson lahinson added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Aug 15, 2024
lahinson
lahinson reviewed Aug 15, 2024
View reviewed changes
Copy link
Contributor

@lahinson lahinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on this! I left some comments for your consideration.

@lahinson lahinson added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Aug 15, 2024
@lahinson lahinson mentioned this pull request Aug 15, 2024
Merged
1 task
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 19, 2024
@openshift-ci
Copy link

openshift-ci bot commented Aug 19, 2024

New changes are detected. LGTM label has been removed.

@amolnar-gh amolnar-gh changed the title (WIP) [enterprise-4.14] TELCODOCS-1958: Adding content for improved SR-IOV Network Operator node draining [enterprise-4.14] TELCODOCS-1958: Adding content for improved SR-IOV Network Operator node draining Aug 19, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 19, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 19, 2024 •
edited by openshift-ci bot
Loading

@amolnar-rh: This pull request references TELCODOCS-1958 which is a valid jira issue.

Details

In response to this:

Version(s): 4.14

Issue: https://issues.redhat.com/browse/TELCODOCS-1958

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
Cherrypicked from the original main and RN PRs:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@amolnar-gh
Copy link
Contributor Author

amolnar-gh commented Aug 19, 2024

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Aug 19, 2024
@amolnar-gh amolnar-gh force-pushed the TELCODOCS-1958-4.14 branch from b206fbc to ad89323 Compare August 19, 2024 09:40
@amolnar-gh
Copy link
Contributor Author

amolnar-gh commented Aug 19, 2024

/retest

@openshift-ci
Copy link

openshift-ci bot commented Aug 19, 2024

@amolnar-rh: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@stevsmit stevsmit added merge-review-in-progress Signifies that the merge review team is reviewing this PR branch/enterprise-4.14 and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Aug 19, 2024
@stevsmit stevsmit added this to the Continuous Release milestone Aug 19, 2024
@stevsmit
Copy link
Member

stevsmit commented Aug 19, 2024

This LGTM. Sometimes "an sriov. . ." is used and other times "a sriov. . ." but that's not enough to hold up a merge review.

@stevsmit stevsmit merged commit 74afa98 into openshift:enterprise-4.14 Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lahinson lahinson lahinson left review comments

Assignees

@SchSeba SchSeba

Labels

branch/enterprise-4.14 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. merge-review-in-progress Signifies that the merge review team is reviewing this PR peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

Continuous Release

Development

Successfully merging this pull request may close these issues.

9 participants

@amolnar-gh @openshift-ci-robot @ocpdocs-previewbot @ealcaniz @SchSeba @evgenLevin @stevsmit @lahinson @rohennes