TELCODOCS-1509: Adding content for improved SR-IOV Network Operator node draining#74464
TELCODOCS-1509: Adding content for improved SR-IOV Network Operator node draining#74464jab-rh merged 1 commit intoopenshift:mainfrom
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@rohennes: This pull request references TELCODOCS-1509 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
1 similar comment
|
@rohennes: This pull request references TELCODOCS-1509 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
size/S
rohennes
changed the title
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
@rohennes: This pull request references TELCODOCS-1509 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
🤖 Thu Feb 05 13:29:30 - Prow CI generated the docs preview: |
rohennes
force-pushed
the
TELCODOCS-1509
branch
3 times, most recently
from
0a2a95b to
086b83d
Compare
openshift-ci
bot
added
size/M
rohennes
force-pushed
the
TELCODOCS-1509
branch
from
086b83d to
498722d
Compare
openshift-ci
bot
added
size/L
|
@rohennes: This pull request references TELCODOCS-1509 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
rohennes
force-pushed
the
TELCODOCS-1509
branch
5 times, most recently
from
dd59688 to
e250318
Compare
|
/test validate-asciidoc |
rohennes
force-pushed
the
TELCODOCS-1509
branch
2 times, most recently
from
1779d1a to
5635435
Compare
rohennes
force-pushed
the
TELCODOCS-1509
branch
from
5635435 to
84271bd
Compare
|
|
||
| The following YAML is an example of a `SriovNetworkNodeState` object created by the SR-IOV Network Operator: | ||
|
|
||
| // Any updates required for this section? |
There was a problem hiding this comment.
I don't think we need it here
|
/lgtm |
|
@evgenLevin: changing LGTM is restricted to collaborators DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@rohennes: This pull request references TELCODOCS-1509 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/label peer-review-needed |
|
/label telco |
openshift-ci
bot
added
peer-review-needed
|
/label peer-review-in-progress |
openshift-ci
bot
added
the
peer-review-in-progress
xenolinux
left a comment
xenolinux
left a comment
There was a problem hiding this comment.
Nice work! I put some suggestions and comments to consider.
/remove-label peer-review-needed
/remove-label peer-review-in-progress
/label peer-review-done
| @@ -0,0 +1,154 @@ | |||
| :_mod-docs-content-type: PROCEDURE | |||
| [id="configure-sr-iov-operator-parallel-nodes_{context}"] | |||
| == Configuring parallel node draining during SR-IOV network policy updates | |||
There was a problem hiding this comment.
| == Configuring parallel node draining during SR-IOV network policy updates | |
| = Configuring parallel node draining during SR-IOV network policy updates |
There was a problem hiding this comment.
...you must use a level one heading ( = ) for the module title.
There was a problem hiding this comment.
Note: If you want this section to be appeared as level 2, you can set leveloffset=+2 for this module, in your assembly file:
For example:
include::modules/nw-sriov-configuring-multiple-nodes.adoc[leveloffset=+2]
| ==== | ||
| * A node can only belong to one SR-IOV network pool configuration. If a node is not part of a pool, it is added to a virtual, default, pool that is configured to drain one node at a time only. | ||
|
|
||
| * The node might reboot during the draining process. |
There was a problem hiding this comment.
| * The node might reboot during the draining process. | |
| * The node might restart during the draining process. |
https://www.ibm.com/docs/en/ibm-style?topic=word-usage#r
Use with caution reboot noun
Reboot is widely recognized among technical users, but where usage permits, use restart.
| * A node can only belong to one SR-IOV network pool configuration. If a node is not part of a pool, it is added to a virtual, default, pool that is configured to drain one node at a time only. | ||
|
|
||
| * The node might reboot during the draining process. |
There was a problem hiding this comment.
| * A node can only belong to one SR-IOV network pool configuration. If a node is not part of a pool, it is added to a virtual, default, pool that is configured to drain one node at a time only. | |
| * The node might reboot during the draining process. | |
| A node can only belong to one SR-IOV network pool configuration. If a node is not part of a pool, it is added to a virtual, default, pool that is configured to drain one node at a time only. | |
| The node might reboot during the draining process. |
IMO. bullets are not required in the note here
openshift-ci
bot
added
peer-review-done
|
/label merge-review-needed |
openshift-ci
bot
added
the
merge-review-needed
|
@rohennes: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
LGTM |
|
/cherry-pick enterprise-4.16 |
|
@jab-rh: new pull request created: #75939 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
jab-rh
removed
the
merge-review-needed
9 participants
TELCODOCS-1509: The SR-IOV Node Operator drains nodes to make SR-IOV node updates. These updates allow it to do this in parallel instead of in sequence for quicker rollout.
Version(s):
4.16+
Issue:
https://issues.redhat.com/browse/TELCODOCS-1509
Link to docs preview:
https://74464--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/hardware_networks/configuring-sriov-device.html#configure-sr-iov-operator-parallel-nodes_configuring-sriov-device
QE review:
Additional information: