Skip to content

OBSDOCS-2646: [Docs] 4.20 doc has outdated Logging doc content #101124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: enterprise-4.20
Choose a base branch
from
Open

OBSDOCS-2646: [Docs] 4.20 doc has outdated Logging doc content #101124

wants to merge 1 commit into from

Conversation

@theashiot
Copy link
Contributor

@theashiot theashiot commented Oct 28, 2025 •
edited
Loading

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 28, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 28, 2025 •
edited by openshift-ci bot
Loading

@theashiot: This pull request references OBSDOCS-2646 which is a valid jira issue.

In response to this:

Version(s): 4.20

Issue: https://issues.redhat.com/browse/OBSDOCS-2646

Link to docs preview:

QE review: Not required

Additional information: This is a manual cherry-pick because this cherry-pick failed: #95117

Original PR: #94807

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 28, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Oct 28, 2025 •
edited
Loading

🤖 Tue Nov 18 14:14:37 - Prow CI generated the docs preview:

https://101124--ocpdocs-pr.netlify.app/
https://101124--ocpdocs-pr.netlify.app/openshift-dedicated/latest/observability/logging/about-logging.html
https://101124--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/logging/about-logging.html
https://101124--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/observability/logging/about-logging.html
https://101124--ocpdocs-pr.netlify.app/openshift-rosa/latest/observability/logging/about-logging.html

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 29, 2025 •
edited by openshift-ci bot
Loading

@theashiot: This pull request references OBSDOCS-2646 which is a valid jira issue.

In response to this:

Version(s): 4.20

Issue: https://issues.redhat.com/browse/OBSDOCS-2646

Link to docs preview:

QE review: Not required

Additional information: This is a manual cherry-pick because this cherry-pick failed: #95117

Original PR: #94807

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 29, 2025 •
edited by openshift-ci bot
Loading

@theashiot: This pull request references OBSDOCS-2646 which is a valid jira issue.

In response to this:

Version(s): 4.20

Issue: https://issues.redhat.com/browse/OBSDOCS-2646

Link to docs preview:

QE review: Not required

Additional information: This is a manual cherry-pick because this cherry-pick failed: #95117

Original PR: #94807

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 29, 2025 •
edited by openshift-ci bot
Loading

@theashiot: This pull request references OBSDOCS-2646 which is a valid jira issue.

In response to this:

Version(s): 4.20

Issue: https://issues.redhat.com/browse/OBSDOCS-2646

Link to docs preview:

QE review: Not required

Additional information: This is a manual cherry-pick because this cherry-pick failed: #95117

Original PR: #94807

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

gabriel-rh
gabriel-rh reviewed Oct 29, 2025
View reviewed changes
Copy link
Contributor

@gabriel-rh gabriel-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the content is never going to be used, just cut it - don't leave the content in the topic map commented out

All the assemblies/modules also need to be cut so they do not get migrated to DITA - this applies to all versions of OCP.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 14, 2025
@openshift-ci openshift-ci bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 14, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 14, 2025
@theashiot theashiot force-pushed the OBSDOCS-2646 branch 2 times, most recently from 3ace41b to 4102a73 Compare November 18, 2025 12:58
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 18, 2025
@openshift-ci openshift-ci bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 18, 2025
@openshift-ci
Copy link

openshift-ci bot commented Nov 18, 2025

@theashiot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@theashiot
Copy link
Contributor Author

theashiot commented Nov 18, 2025

Hi @gabriel-rh, thanks, I've removed the files that are no longer needed. Can you please have another look?

thanks,
ashwin

@theashiot theashiot mentioned this pull request Nov 26, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gabriel-rh gabriel-rh gabriel-rh left review comments

Assignees

No one assigned

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@theashiot @openshift-ci-robot @ocpdocs-previewbot @gabriel-rh @openshift-merge-robot