Skip to content

[enterprise-4.16] OSDOCS-18463 [NETOBSERV] CQA Vale rule fixes that are not Callouts#108272

Merged
lahinson merged 1 commit intoopenshift:enterprise-4.16from
gwynnemonahan:manual-cherry-pick-enterprise-4-16-OSDOCS-18463
Mar 17, 2026
Merged

[enterprise-4.16] OSDOCS-18463 [NETOBSERV] CQA Vale rule fixes that are not Callouts#108272
lahinson merged 1 commit intoopenshift:enterprise-4.16from
gwynnemonahan:manual-cherry-pick-enterprise-4-16-OSDOCS-18463

Conversation

@gwynnemonahan
Copy link
Copy Markdown
Contributor

@gwynnemonahan gwynnemonahan commented Mar 12, 2026

Manual cherry-pick for enterprise-4.16.

Commit: e4995ce

Original PR: #107356

Version(s):
4.16

Link to docs preview:

QE review:
QE is not required for this PR.

Additional information:

  • 1 less file because modules/network-observability-viewing-network-events.adoc does not apply to 4.16.
  • ⚠️ ⚠️ Callouts are being addressed by OSDOCS-14480 ⚠️ ⚠️
  • In some instances, Callouts were already updated.
  • This PR is a consolidation of a number of other PRs and Jira issues that were opened/created in Aug/Sept 2025.
  • The majority of the files in those initial PRs and Jira issues all pass Vale checks.
  • This PR ONLY addresses Vale rule violations for the remaining files. Rather than a bunch of XS PRs that contain 1 or 2 files, I consolidated the remaining violations into 1 Jira, and they are being addressed in this PR.
  • Where necessary, such as for examples that were included in PROCEDURES, the content was copy/pasted as is into a new file.
  • In other instances, some rewording was done to pass Vale and style checks, such as in ‎modules/network-observability-RTT.adoc
  • Other issues will be addressed in separate PRs.
  • JTBD will be addressed separately.

@openshift-ci openshift-ci Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 12, 2026
Comment thread modules/network-observability-flowmetrics-charts-examples.adoc
Comment thread modules/network-observability-flowmetrics-charts-examples.adoc
Comment thread observability/network_observability/metrics-alerts-dashboards.adoc Outdated
@gwynnemonahan gwynnemonahan force-pushed the manual-cherry-pick-enterprise-4-16-OSDOCS-18463 branch from 0c162d2 to 447c2fb Compare March 12, 2026 19:16
Comment thread modules/network-observability-configuring-custom-metrics-examples.adoc Outdated
@gwynnemonahan gwynnemonahan force-pushed the manual-cherry-pick-enterprise-4-16-OSDOCS-18463 branch from 2a4f4c5 to 0912b33 Compare March 12, 2026 19:33
Comment thread modules/network-observability-configuring-custom-metrics-examples.adoc Outdated
@gwynnemonahan gwynnemonahan force-pushed the manual-cherry-pick-enterprise-4-16-OSDOCS-18463 branch 2 times, most recently from 05b6ea9 to 610894b Compare March 12, 2026 20:52
@gwynnemonahan
Copy link
Copy Markdown
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci Bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Mar 12, 2026
@gwynnemonahan gwynnemonahan force-pushed the manual-cherry-pick-enterprise-4-16-OSDOCS-18463 branch 2 times, most recently from cc9728c to cf242da Compare March 12, 2026 21:37
* link:https://docs.redhat.com/en/documentation/monitoring_stack_for_red_hat_openshift/4.16/html/managing_alerts/managing-alerts-as-a-developer#creating-alerting-rules-for-user-defined-projects_managing-alerts-as-a-developer[Creating alerting rules for user-defined projects]
* xref:../../support/troubleshooting/investigating-monitoring-issues.adoc#determining-why-prometheus-is-consuming-disk-space_investigating-monitoring-issues[Troubleshooting high cardinality metrics- Determining why Prometheus is consuming a lot of disk space]
* link:https://docs.redhat.com/en/documentation/monitoring_stack_for_red_hat_openshift/4.17/html/managing_alerts/managing-alerts-as-a-developer#creating-alerting-rules-for-user-defined-projects_managing-alerts-as-a-developer[Creating alerting rules for user-defined projects]
* xref:../../support/troubleshooting/investigating-monitoring-issues.adoc#determining-why-prometheus-is-consuming-disk-space_investigating-monitoring-issues[Troubleshooting high cardinality metrics- Determining why Prometheus is consuming a lot of disk space] No newline at end of file
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 [error] RedHat.TermsErrors: Use 'many' or 'much' rather than 'a lot of'. For more information, see RedHat.TermsErrors.

@lahinson lahinson added merge-review-in-progress Signifies that the merge review team is reviewing this PR branch/enterprise-4.16 and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Mar 17, 2026
@lahinson lahinson added this to the Continuous Release milestone Mar 17, 2026
Copy link
Copy Markdown
Contributor

@lahinson lahinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gwynnemonahan Just one question for you. I'll be happy to merge this when you're ready. Feel free to ping me to let me know!

Comment thread observability/network_observability/metrics-alerts-dashboards.adoc Outdated
@gwynnemonahan gwynnemonahan force-pushed the manual-cherry-pick-enterprise-4-16-OSDOCS-18463 branch from 2768996 to cf06128 Compare March 17, 2026 16:36
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Mar 17, 2026

@gwynnemonahan: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@lahinson lahinson merged commit a4488b2 into openshift:enterprise-4.16 Mar 17, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.16 merge-review-in-progress Signifies that the merge review team is reviewing this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants