Skip to content

OSDOCS-18463 [NETOBSERV] CQA Vale rule fixes that are not Callouts#107356

Merged
ShaunaDiaz merged 1 commit intoopenshift:mainfrom
gwynnemonahan:OSDOCS-18463
Mar 12, 2026
Merged

OSDOCS-18463 [NETOBSERV] CQA Vale rule fixes that are not Callouts#107356
ShaunaDiaz merged 1 commit intoopenshift:mainfrom
gwynnemonahan:OSDOCS-18463

Conversation

@gwynnemonahan
Copy link
Copy Markdown
Contributor

@gwynnemonahan gwynnemonahan commented Feb 25, 2026

OSDOCS-18463 [NETOBSERV] CQA Vale rule fixes that are not Callouts

Version(s):
4.16+ since CQA related

Issue:
https://issues.redhat.com/browse/OSDOCS-18463

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

  • ⚠️ ⚠️ Callouts are being addressed by OSDOCS-14480 ⚠️ ⚠️
  • In some instances, Callouts were already updated.
  • This PR is a consolidation of a number of other PRs and Jira issues that were opened/created in Aug/Sept 2025. The majority of the files in those initial PRs and Jira issues all pass Vale checks.
  • This PR ONLY addresses Vale rule violations for the remaining files. Rather than a bunch of XS PRs that contain 1 or 2 files, I consolidated the remaining violations into 1 Jira, and they are being addressed in this PR.
  • Where necessary, such as for examples that were included in PROCEDURES, the content was copy/pasted as is into a new file.
  • In other instances, some rewording was done to pass Vale and style checks, such as in ‎modules/network-observability-RTT.adoc
  • Other issues will be addressed in separate PRs.
  • JTBD will be addressed separately.

@openshift-ci openshift-ci Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 25, 2026
Comment thread modules/network-observability-exporting-traffic-flow-data.adoc Outdated
Comment thread modules/network-observability-flowmetrics-charts-examples.adoc
Comment thread modules/network-observability-flowmetrics-charts-examples.adoc
@gwynnemonahan gwynnemonahan force-pushed the OSDOCS-18463 branch 2 times, most recently from c0a0353 to e0e3ec7 Compare February 26, 2026 14:05
@gwynnemonahan
Copy link
Copy Markdown
Contributor Author

/retest

Comment thread modules/network-observability-RTT.adoc Outdated
Comment thread modules/network-observability-RTT.adoc Outdated
Comment thread modules/network-observability-RTT.adoc Outdated
Comment thread modules/network-observability-RTT.adoc Outdated
Comment thread modules/network-observability-RTT.adoc Outdated
Comment thread modules/network-observability-RTT.adoc
Comment thread modules/network-observability-RTT.adoc Outdated
Comment thread modules/network-observability-RTT.adoc Outdated
Comment thread modules/network-observability-RTT.adoc
@Amoghrd
Copy link
Copy Markdown

Amoghrd commented Feb 26, 2026

/label qe-approved

@openshift-ci openshift-ci Bot added the qe-approved Signifies that QE has signed off on this PR label Feb 26, 2026
@Amoghrd
Copy link
Copy Markdown

Amoghrd commented Feb 26, 2026

/assign @jotak

Copy link
Copy Markdown

@jotak jotak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2026
@gwynnemonahan
Copy link
Copy Markdown
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci Bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Feb 27, 2026
@gwynnemonahan
Copy link
Copy Markdown
Contributor Author

Rebased 03/12/2026 AM.

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Mar 12, 2026

@gwynnemonahan: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ShaunaDiaz ShaunaDiaz merged commit aff2966 into openshift:main Mar 12, 2026
2 checks passed
@ShaunaDiaz
Copy link
Copy Markdown
Contributor

/cherrypick enterprise-4.22

@ShaunaDiaz
Copy link
Copy Markdown
Contributor

/cherrypick enterprise-4.21

@ShaunaDiaz
Copy link
Copy Markdown
Contributor

/cherrypick enterprise-4.20

@ShaunaDiaz
Copy link
Copy Markdown
Contributor

/cherrypick enterprise-4.19

@ShaunaDiaz
Copy link
Copy Markdown
Contributor

/cherrypick enterprise-4.18

@ShaunaDiaz
Copy link
Copy Markdown
Contributor

/cherrypick enterprise-4.17

@ShaunaDiaz
Copy link
Copy Markdown
Contributor

/cherrypick enterprise-4.16

@openshift-cherrypick-robot
Copy link
Copy Markdown

@ShaunaDiaz: new pull request created: #108268

Details

In response to this:

/cherrypick enterprise-4.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link
Copy Markdown

@ShaunaDiaz: new pull request created: #108269

Details

In response to this:

/cherrypick enterprise-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link
Copy Markdown

@ShaunaDiaz: new pull request created: #108270

Details

In response to this:

/cherrypick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link
Copy Markdown

@ShaunaDiaz: #107356 failed to apply on top of branch "enterprise-4.19":

Applying: OSDOCS-18463 [NETOBSERV] CQA Vale rule fixes that are not Callouts
Using index info to reconstruct a base tree...
M	modules/network-observability-RTT.adoc
M	modules/network-observability-configuring-custom-metrics.adoc
M	modules/network-observability-flowmetrics-charts.adoc
M	modules/network-observability-viewing-network-events.adoc
M	observability/network_observability/metrics-alerts-dashboards.adoc
Falling back to patching base and 3-way merge...
Auto-merging observability/network_observability/metrics-alerts-dashboards.adoc
Auto-merging modules/network-observability-viewing-network-events.adoc
Auto-merging modules/network-observability-flowmetrics-charts.adoc
Auto-merging modules/network-observability-configuring-custom-metrics.adoc
Auto-merging modules/network-observability-RTT.adoc
CONFLICT (content): Merge conflict in modules/network-observability-RTT.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 OSDOCS-18463 [NETOBSERV] CQA Vale rule fixes that are not Callouts

Details

In response to this:

/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link
Copy Markdown

@ShaunaDiaz: #107356 failed to apply on top of branch "enterprise-4.18":

Applying: OSDOCS-18463 [NETOBSERV] CQA Vale rule fixes that are not Callouts
Using index info to reconstruct a base tree...
M	modules/network-observability-RTT.adoc
M	modules/network-observability-configuring-custom-metrics.adoc
M	modules/network-observability-flowmetrics-charts.adoc
M	modules/network-observability-viewing-network-events.adoc
M	observability/network_observability/metrics-alerts-dashboards.adoc
M	observability/network_observability/observing-network-traffic.adoc
Falling back to patching base and 3-way merge...
Auto-merging observability/network_observability/observing-network-traffic.adoc
Auto-merging observability/network_observability/metrics-alerts-dashboards.adoc
Auto-merging modules/network-observability-viewing-network-events.adoc
Auto-merging modules/network-observability-flowmetrics-charts.adoc
Auto-merging modules/network-observability-configuring-custom-metrics.adoc
Auto-merging modules/network-observability-RTT.adoc
CONFLICT (content): Merge conflict in modules/network-observability-RTT.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 OSDOCS-18463 [NETOBSERV] CQA Vale rule fixes that are not Callouts

Details

In response to this:

/cherrypick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link
Copy Markdown

@ShaunaDiaz: #107356 failed to apply on top of branch "enterprise-4.17":

Applying: OSDOCS-18463 [NETOBSERV] CQA Vale rule fixes that are not Callouts
Using index info to reconstruct a base tree...
M	modules/network-observability-RTT.adoc
M	modules/network-observability-configuring-custom-metrics.adoc
M	modules/network-observability-flowmetrics-charts.adoc
M	modules/network-observability-viewing-network-events.adoc
M	observability/network_observability/metrics-alerts-dashboards.adoc
Falling back to patching base and 3-way merge...
Auto-merging observability/network_observability/metrics-alerts-dashboards.adoc
Auto-merging modules/network-observability-viewing-network-events.adoc
Auto-merging modules/network-observability-flowmetrics-charts.adoc
Auto-merging modules/network-observability-configuring-custom-metrics.adoc
Auto-merging modules/network-observability-RTT.adoc
CONFLICT (content): Merge conflict in modules/network-observability-RTT.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 OSDOCS-18463 [NETOBSERV] CQA Vale rule fixes that are not Callouts

Details

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link
Copy Markdown

@ShaunaDiaz: #107356 failed to apply on top of branch "enterprise-4.16":

Applying: OSDOCS-18463 [NETOBSERV] CQA Vale rule fixes that are not Callouts
Using index info to reconstruct a base tree...
M	modules/network-observability-RTT.adoc
M	modules/network-observability-configuring-custom-metrics.adoc
M	modules/network-observability-flowmetrics-charts.adoc
A	modules/network-observability-viewing-network-events.adoc
M	observability/network_observability/metrics-alerts-dashboards.adoc
M	observability/network_observability/observing-network-traffic.adoc
Falling back to patching base and 3-way merge...
Auto-merging observability/network_observability/observing-network-traffic.adoc
Auto-merging observability/network_observability/metrics-alerts-dashboards.adoc
CONFLICT (content): Merge conflict in observability/network_observability/metrics-alerts-dashboards.adoc
CONFLICT (modify/delete): modules/network-observability-viewing-network-events.adoc deleted in HEAD and modified in OSDOCS-18463 [NETOBSERV] CQA Vale rule fixes that are not Callouts. Version OSDOCS-18463 [NETOBSERV] CQA Vale rule fixes that are not Callouts of modules/network-observability-viewing-network-events.adoc left in tree.
Auto-merging modules/network-observability-flowmetrics-charts.adoc
Auto-merging modules/network-observability-configuring-custom-metrics.adoc
Auto-merging modules/network-observability-RTT.adoc
CONFLICT (content): Merge conflict in modules/network-observability-RTT.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 OSDOCS-18463 [NETOBSERV] CQA Vale rule fixes that are not Callouts

Details

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants