OSDOCS-18938: adds creating virt servers to MCP gateway docs#109621
OSDOCS-18938: adds creating virt servers to MCP gateway docs#109621ShaunaDiaz merged 1 commit intoopenshift:mcp-gateway-docs-tpfrom
Conversation
|
@ShaunaDiaz: This pull request references OSDOCS-18938 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
openshift-ci
Bot
added
the
size/L
|
@ShaunaDiaz: This pull request references OSDOCS-18938 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
ShaunaDiaz
changed the title
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
|
🤖 Mon Apr 20 14:04:50 - Prow CI generated the docs preview: https://109621--ocpdocs-pr.netlify.app/rhcl/latest/mcp_gateway_config/mcp-gateway-creating-virtual-mcp-servers.html |
ShaunaDiaz
force-pushed
the
OSDOCS-18938
branch
2 times, most recently
from
b3c5919 to
2a7ca91
Compare
ShaunaDiaz
changed the title
openshift-ci
Bot
removed
the
do-not-merge/work-in-progress
|
@ShaunaDiaz: This pull request references OSDOCS-18938 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@ShaunaDiaz: This pull request references OSDOCS-18938 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@ShaunaDiaz: This pull request references OSDOCS-18938 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
👀 |
|
couple of small suggestions |
ShaunaDiaz
force-pushed
the
OSDOCS-18938
branch
from
d9ec07c to
47674a4
Compare
|
👀 |
ShaunaDiaz
force-pushed
the
OSDOCS-18938
branch
from
47674a4 to
0f00aa1
Compare
|
@ShaunaDiaz: This pull request references OSDOCS-18938 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
ShaunaDiaz
added
the
do-not-merge/hold
ShaunaDiaz
added
merge-review-needed
ShaunaDiaz
force-pushed
the
OSDOCS-18938
branch
from
0f00aa1 to
cc2b11d
Compare
ShaunaDiaz
added
the
merge-review-needed
ShaunaDiaz
force-pushed
the
OSDOCS-18938
branch
3 times, most recently
from
6ee77a9 to
bbe41d3
Compare
skopacz1
added
the
merge-review-in-progress
skopacz1
left a comment
skopacz1
left a comment
There was a problem hiding this comment.
I am not sure what the QE situation looks like with your team right now, but I trust that you have satisfied/will satisfy the spirit of the QE review by the time you merge this PR (or fold the entire branch into live docs).
For the content itself, left some feedback but otherwise LGTM!
skopacz1
added
ok-to-merge
and removed
merge-review-in-progress
trepel
left a comment
trepel
left a comment
There was a problem hiding this comment.
A few issues found that would be good to address, nothing major though.
ShaunaDiaz
force-pushed
the
OSDOCS-18938
branch
from
bbe41d3 to
acfa658
Compare
trepel
left a comment
trepel
left a comment
There was a problem hiding this comment.
Just two small comments, it looks good otherwise!
ShaunaDiaz
removed
the
do-not-merge/hold
|
@ShaunaDiaz: This pull request references OSDOCS-18938 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
ShaunaDiaz
force-pushed
the
OSDOCS-18938
branch
from
acfa658 to
bbb9812
Compare
|
@ShaunaDiaz: This pull request references OSDOCS-18938 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
ShaunaDiaz
force-pushed
the
OSDOCS-18938
branch
from
bbb9812 to
8a68feb
Compare
trepel
left a comment
trepel
left a comment
There was a problem hiding this comment.
LGTM
I can still see data-tools instead of data_tools being used but that's minor enough not blocking the merge.
ShaunaDiaz
force-pushed
the
OSDOCS-18938
branch
from
8a68feb to
35835ba
Compare
|
@ShaunaDiaz: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
7 participants
Version(s):
mcp-gateway-docs-tp
Issue:
OSDOCS-18938
Link to docs preview:
https://109621--ocpdocs-pr.netlify.app/rhcl/latest/mcp_gateway_config/mcp-gateway-creating-virtual-mcp-servers.html
QE review:
Additional information:
Docs merge reviewer, the
mcp-gateway-docs-tpis a Release branch, so content work is incremental. The entire branch will be integrated into therhcl-docs-main,rhcl-docs-1.3, andrhcl-docs-1.4docs in late April, and therefore, not published anywhere now.