Fix external MCP Gateway guides to match upstream corrections#110583
Merged
ShaunaDiaz merged 1 commit intoopenshift:mcp-gateway-docs-tpfrom Apr 24, 2026
Merged
Conversation
|
Skipping CI for Draft Pull Request. |
Author
ShaunaDiaz
reviewed
Apr 24, 2026
Contributor
ShaunaDiaz
left a comment
There was a problem hiding this comment.
LGTM also; @jasonmadigan would you mind squashing the commits, then I can merge
a4e52e6 to
37500b0
Compare
Author
|
@ShaunaDiaz thanks! squashed |
|
@jasonmadigan: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes found during guide walkthrough testing against a live TP cluster. Covers three guides:
External MCP server registration (PR #109575)
x-mcp-api-keyheader from AuthPolicy example (removed upstream in Kuadrant/mcp-gateway@460ef27){service-mesh}attribute reference in TLS module (attribute was renamed, then reverted -- now consistent with branch state)_<tls_mode>_placeholder that doesn't exist in the YAMLoc get mcpsr -Aexample output columns in both external and on-prem guides to match actual output (addsPATH,TOOLS,CREDENTIALScolumns, corrects column order)Virtual MCP server verification (PR #109621)
jqto prerequisites (used in curl commands but not listed, fixed upstream in Kuadrant/mcp-gateway@521b976)Observability / OpenTelemetry (PR #109810)
OpenTelemetryCollectorCR API version fromv1alpha1tov1beta1--v1alpha1with structured config fails on current Red Hat OTel operator (v0.144.0) with a conversion webhook erroroc set envcommand to match the placeholder style used in the collector CR (was hardcoded tomcp-gateway-system)