Skip to content

Fix external MCP Gateway guides to match upstream corrections#110583

Merged
ShaunaDiaz merged 1 commit intoopenshift:mcp-gateway-docs-tpfrom
jasonmadigan:fix/ext-mcp-server-guide-patches
Apr 24, 2026
Merged

Fix external MCP Gateway guides to match upstream corrections#110583
ShaunaDiaz merged 1 commit intoopenshift:mcp-gateway-docs-tpfrom
jasonmadigan:fix/ext-mcp-server-guide-patches

Conversation

@jasonmadigan
Copy link
Copy Markdown

@jasonmadigan jasonmadigan commented Apr 22, 2026

Summary

Fixes found during guide walkthrough testing against a live TP cluster. Covers three guides:

External MCP server registration (PR #109575)

  • Remove stale x-mcp-api-key header from AuthPolicy example (removed upstream in Kuadrant/mcp-gateway@460ef27)
  • Fix broken {service-mesh} attribute reference in TLS module (attribute was renamed, then reverted -- now consistent with branch state)
  • Fix TLS module bullet text referencing a _<tls_mode>_ placeholder that doesn't exist in the YAML
  • Fix oc get mcpsr -A example output columns in both external and on-prem guides to match actual output (adds PATH, TOOLS, CREDENTIALS columns, corrects column order)
  • Fix typo in verify module

Virtual MCP server verification (PR #109621)

  • Add jq to prerequisites (used in curl commands but not listed, fixed upstream in Kuadrant/mcp-gateway@521b976)
  • Fix example initialize output: server name, version, and capabilities don't match actual broker response
  • Fix command incorrectly shown as expected output (session ID echo)
  • Standardise URL placeholder format across all curl steps

Observability / OpenTelemetry (PR #109810)

  • Fix OpenTelemetryCollector CR API version from v1alpha1 to v1beta1 -- v1alpha1 with structured config fails on current Red Hat OTel operator (v0.144.0) with a conversion webhook error
  • Parameterise namespace and collector name in oc set env command to match the placeholder style used in the collector CR (was hardcoded to mcp-gateway-system)

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 22, 2026
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 22, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 22, 2026
@jasonmadigan jasonmadigan changed the title Fix external MCP server guide to match upstream corrections WIP: Fix external MCP server guide to match upstream corrections Apr 22, 2026
@openshift-ci openshift-ci Bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 22, 2026
@jasonmadigan jasonmadigan marked this pull request as ready for review April 23, 2026 15:45
@jasonmadigan jasonmadigan changed the title WIP: Fix external MCP server guide to match upstream corrections Fix external MCP server guide to match upstream corrections Apr 23, 2026
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 23, 2026
@jasonmadigan
Copy link
Copy Markdown
Author

Copy link
Copy Markdown

@trepel trepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jasonmadigan jasonmadigan changed the title Fix external MCP server guide to match upstream corrections Fix external MCP Gateway guides to match upstream corrections Apr 24, 2026
Copy link
Copy Markdown
Contributor

@ShaunaDiaz ShaunaDiaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM also; @jasonmadigan would you mind squashing the commits, then I can merge

@jasonmadigan jasonmadigan force-pushed the fix/ext-mcp-server-guide-patches branch from a4e52e6 to 37500b0 Compare April 24, 2026 10:42
@jasonmadigan
Copy link
Copy Markdown
Author

@ShaunaDiaz thanks! squashed

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 24, 2026

@jasonmadigan: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ShaunaDiaz ShaunaDiaz merged commit 5101366 into openshift:mcp-gateway-docs-tp Apr 24, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants