OSDOCS-17718: adds authentication to MCP gateway docs#109672
OSDOCS-17718: adds authentication to MCP gateway docs#109672ShaunaDiaz merged 1 commit intoopenshift:mcp-gateway-docs-tpfrom
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@ShaunaDiaz: This pull request references OSDOCS-17718 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
Bot
added
do-not-merge/work-in-progress
|
🤖 Fri Apr 17 11:02:47 - Prow CI generated the docs preview: https://109672--ocpdocs-pr.netlify.app/ |
ShaunaDiaz
force-pushed
the
OSDOCS-17718
branch
2 times, most recently
from
ff93743 to
566606c
Compare
ShaunaDiaz
changed the title
openshift-ci
Bot
removed
the
do-not-merge/work-in-progress
|
@ShaunaDiaz: This pull request references OSDOCS-17718 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@ShaunaDiaz: This pull request references OSDOCS-17718 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@ShaunaDiaz: This pull request references OSDOCS-17718 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
|
||
| .Procedure | ||
|
|
||
| //Q: would it be easier for our users to add this listener at install when we configure listeners? see https://github.com/openshift/openshift-docs/pull/109364 |
There was a problem hiding this comment.
I'd say either is technically correct
If the listener config guide (#109364) is a prerequisite for this guide, adding the identity provider listener there as an optional step avoids repeating the oc patch gateway pattern.
Works fine here standalone too
ShaunaDiaz
force-pushed
the
OSDOCS-17718
branch
from
954ba0f to
109011c
Compare
ShaunaDiaz
force-pushed
the
OSDOCS-17718
branch
from
109011c to
93013ef
Compare
|
@ShaunaDiaz: This pull request references OSDOCS-17718 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
ShaunaDiaz
added
do-not-merge/hold
ShaunaDiaz
force-pushed
the
OSDOCS-17718
branch
2 times, most recently
from
8dd2c63 to
1d57293
Compare
bscott-rh
added
merge-review-in-progress
bscott-rh
left a comment
bscott-rh
left a comment
There was a problem hiding this comment.
Merge review LGTM. I left a couple of nits that are up to you. I also want to mention that while you used {mcpg} in the assembly heading, you didn't use it for most of the instances of "MCP gateway" in the rest of the doc.
bscott-rh
added
ok-to-merge
and removed
merge-review-in-progress
ShaunaDiaz
force-pushed
the
OSDOCS-17718
branch
from
1d57293 to
f581357
Compare
trepel
left a comment
trepel
left a comment
There was a problem hiding this comment.
A few small comments, but it looks good otherwise
ShaunaDiaz
force-pushed
the
OSDOCS-17718
branch
from
f581357 to
3436cae
Compare
|
@ShaunaDiaz: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
trepel
left a comment
trepel
left a comment
There was a problem hiding this comment.
One small comment but it does not block approval. LGTM.
ShaunaDiaz
removed
the
do-not-merge/hold
7 participants
Version(s):
mcp-gateway-docs-tp
Issue:
OSDOCS-17718
Link to docs preview:
https://109672--ocpdocs-pr.netlify.app/rhcl/latest/mcp_gateway_config/mcp-gateway-authentication.html
QE review:
Additional information:
Docs merge reviewer, the
mcp-gateway-docs-tpis a Release branch, so content work is incremental. The entire branch will be integrated into therhcl-docs-main,rhcl-docs-1.3andrhcl-docs-1.4docs in late April, and therefore, not published anywhere now.