update mcp-gateway authn/authz guides#110677
update mcp-gateway authn/authz guides#110677ShaunaDiaz merged 1 commit intoopenshift:mcp-gateway-docs-tpfrom
Conversation
openshift-ci
Bot
added
the
size/M
|
🤖 Fri Apr 24 11:48:53 - Prow CI generated the docs preview: https://110677--ocpdocs-pr.netlify.app/rhcl/latest/mcp_gateway_config/mcp-gateway-authentication.html |
Patryk-Stefanski
force-pushed
the
fix-auth-authz-docs
branch
from
2f17d5e to
cd1c260
Compare
| + | ||
| [source,json,subs="+quotes"] | ||
| ---- | ||
| $ oc patch gateway _<mcp_gateway>_ -n _<gateway_system>_ --type json -p '[ |
There was a problem hiding this comment.
should this section, lines 44-50 in the install doc be updated to match this?
- we can make the listener a prereq to this procedure
- add a note to the install doc that you need to config this listener to create authorization
- then we can remove the step from this procedure
WDYT?
There was a problem hiding this comment.
sounds good to me, I removed it from this pr and added it as a prereq. Do you want to add it to your current installation PR, or will I create a follow-up PR?
There was a problem hiding this comment.
I can add it to the installation PR, but since you removed it from this PR I can't see it, so I might miss something.
| ---- | ||
| $ oc apply -f _<mcp_tool_auth_policy.yaml>_ | ||
| $ oc apply -f - <<EOF | ||
| <AuthPolicy CR from the previous step> |
There was a problem hiding this comment.
| <AuthPolicy CR from the previous step> | |
| _<mcp_tool_auth_policy.yaml>_ |
user-replaceable values can only look like this
I also don't think the EOF works when we separate file creation from application? (having the yaml in one step and application of the resource in a second step is preferred in docs)
Patryk-Stefanski
force-pushed
the
fix-auth-authz-docs
branch
from
f224922 to
7ce29ce
Compare
ShaunaDiaz
left a comment
ShaunaDiaz
left a comment
There was a problem hiding this comment.
@Patryk-Stefanski would you mind squashing the commits and fixing that one +? Then I can merge this.
Patryk-Stefanski
force-pushed
the
fix-auth-authz-docs
branch
from
7ce29ce to
8d6c0c3
Compare
|
@Patryk-Stefanski: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
4 participants
Version(s):
mcp-gateway-docs-tp
Issue:
OSDOCS-17719
OSDOCS-17718
Link to docs preview:
https://110677--ocpdocs-pr.netlify.app/rhcl/latest/mcp_gateway_config/mcp-gateway-authentication.html
https://110677--ocpdocs-pr.netlify.app/rhcl/latest/mcp_gateway_config/mcp-gateway-authorization.html
QE review:
Additional information:
See #109794 and #109672 for context.