OSDOCS-17040: platform agnostic CQA#115208
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@skopacz1: This pull request references OSDOCS-17040 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
Bot
added
the
size/M
|
🤖 Thu Jul 16 18:07:22 - Prow CI generated the docs preview: |
skopacz1
added
the
merge-review-needed
ShaunaDiaz
added
merge-review-in-progress
ShaunaDiaz
left a comment
ShaunaDiaz
left a comment
There was a problem hiding this comment.
few thoughts, otherwise lgtm
| For a cluster that contains user-provisioned infrastructure, you must deploy all | ||
| of the required machines. | ||
|
|
||
| This section describes the requirements for deploying {product-title} on user-provisioned infrastructure. No newline at end of file |
There was a problem hiding this comment.
| This section describes the requirements for deploying {product-title} on user-provisioned infrastructure. |
no self-referential text
There was a problem hiding this comment.
This is intentionally kept as its own paragraph so it's not part of the short description
| = Requirements for a cluster with user-provisioned infrastructure | ||
|
|
||
| [role="_abstract"] | ||
| For a cluster that contains user-provisioned infrastructure, you must deploy all |
There was a problem hiding this comment.
| For a cluster that contains user-provisioned infrastructure, you must deploy all | |
| For a cluster that contains user-provisioned infrastructure, you must deploy all of the required machines. |
no line breaks
There was a problem hiding this comment.
Good point, no need to keep existing hard wrapping if I am making a new module anyways
|
|
||
| [role="_abstract"] | ||
| For a cluster that contains user-provisioned infrastructure, you must deploy all | ||
| of the required machines. |
There was a problem hiding this comment.
| of the required machines. |
| [id="installation-requirements-user-infra_{context}"] | ||
| = Requirements for a cluster with user-provisioned infrastructure | ||
|
|
||
| [role="_abstract"] |
There was a problem hiding this comment.
I don't think a module that is just an abstract is valid; can this content go somewhere else?
There was a problem hiding this comment.
If anything the only alternative would be to delete this instead of moving it anywhere, imo. But we have also been modularizing these little stubs in a lot of cases for install CQAs (not sure about how consistently across the entire docs), so I am in favor of keeping it and worrying about it later during the quality pass of CQAs post-migration.
There was a problem hiding this comment.
I was checking around, and it is NOT valid, so this will break migration. Let me find the resource and Slack it over to you.
ShaunaDiaz
removed
the
merge-review-in-progress
|
@skopacz1: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/cherrypick enterprise-4.20 |
|
/cherrypick enterprise-4.21 |
|
/cherrypick enterprise-4.22 |
|
@skopacz1: new pull request created: #115605 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@skopacz1: new pull request created: #115606 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@skopacz1: new pull request created: #115607 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@skopacz1: new pull request created: #115608 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
6 participants
OSDOCS-17040
Version(s): 4.20+
CQA for platform agnostic install docs
QE review: QE review not required IMO, let me know if you see anything that makes you disagree.
Previews: