OSDOCS: Note that changing cgroupMode reboots nodes - #117208
OSDOCS: Note that changing cgroupMode reboots nodes#117208gauravsoniiii wants to merge 1 commit into
Conversation
Changing nodes.config spec.cgroupMode updates MachineConfig kernel arguments; the MCO drains and reboots nodes. The procedure only described SchedulingDisabled → Ready, which omitted the reboot.
|
Hi @gauravsoniiii. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@gauravsoniiii: The label(s) `/label peer-review-needed
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/label merge-review-needed |
|
@gauravsoniiii: The label(s) DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Changing nodes.config spec.cgroupMode updates MachineConfig kernel arguments; the MCO drains and reboots nodes. The procedure only described SchedulingDisabled → Ready, which omitted the reboot.
Jira:
Description:
spec.cgroupModeonnodes.config/clustercauses the Machine Config Operator (MCO) to drain and reboot nodes.Ready,SchedulingDisabledand returning toReady, which can be read as a non-disruptive config apply. In practice, this change updates MachineConfigkernelArguments, so nodes must reboot for the new cgroup configuration to take effect.Version(s):
Issue:
The procedure "Configuring Linux cgroup" (nodes-clusters-cgroups-2) does not state that changing
spec.cgroupModeonnodes.config/clustercauses the Machine Config Operator to drain and reboot nodes.Changing
cgroupModerenders new MachineConfigs with updatedkernelArguments(systemd.unified_cgroup_hierarchy,cgroup_no_v1, etc.). Kernel-argument changes only take effect after a full node reboot (standard MCO cordon → drain → reboot → uncordon behavior). The published Verification steps only mentionReady,SchedulingDisabledand return toReady, which customers read as a non-disruptive config apply.Link to docs preview:
QE review:
Additional information:
modules/nodes-clusters-cgroups-2.adoc