NO-JIRA: Fix oc-mirror v2 verification command typo - #119252
Conversation
Use the hyphenated oc-mirror binary name for the v2 --help verification command, consistent with other oc-mirror v2 docs. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
@hongkailiu: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
wking
left a comment
There was a problem hiding this comment.
Confirming precedence:
$ git log --oneline -1 origin/main
a798ea8be4d (origin/main, origin/HEAD) Merge pull request #118580 from mburke5678/mco-boot-image-update-aws-mktplace
$ git grep -oh 'oc.mirror' a798ea8be4d | sort | uniq -c | sort -n
4 oc_mirror
8 oc#mirror
77 oc mirror
706 oc-mirrorIf folks want to look at some of the other oc mirror references, in this pull or follow-up work, here's the start of an audit:
$ git grep 'oc mirror' a798ea8be4d | sed 's/^[^:]*:\([^:]*\):.*/\1/' | sort | uniq -c | sort -n | tail
2 modules/telco-core-disconnected-environment.adoc
3 modules/hcp-dc-image-mirror.adoc
3 modules/installation-initializing-manual.adoc
3 modules/oc-mirror-command-reference-v2.adoc
3 modules/oc-mirror-disk-to-mirror.adoc
4 modules/microshift-oc-mirror-list-ops-catalogs.adoc
4 modules/oc-mirror-command-reference.adoc
4 modules/oc-mirror-creating-image-set-config.adoc
4 modules/preparing-an-initial-cluster-deployment-for-mce-disconnected.adoc
5 modules/oc-mirror-enclave-support.adoc
$ git grep 'oc mirror' a798ea8be4d -- modules/oc-mirror-enclave-support.adoc
a798ea8be4d:modules/oc-mirror-enclave-support.adoc:The central registry is situated within a secure network, specifically a disconnected environment, and is not directly linked to the public internet. But the user must execute `oc mirror` in an environment with access to the public internet.
a798ea8be4d:modules/oc-mirror-enclave-support.adoc:$ oc mirror --v2 -c isc.yaml file://<file_path>/enterprise-content
a798ea8be4d:modules/oc-mirror-enclave-support.adoc:$ oc mirror --v2 -c isc.yaml --from file://<disconnected_environment_file_path>/enterprise-content docker://<enterprise_registry.in>/
a798ea8be4d:modules/oc-mirror-enclave-support.adoc:$ oc mirror --v2 -c isc-enclave.yaml
a798ea8be4d:modules/oc-mirror-enclave-support.adoc:$ oc mirror --v2 -c isc-enclave.yaml --from file://local-disk docker://registry.enc1.inBut I don't see a reason to make a completely clean audit a prereq for incremental improvement:
/lgtm
|
@snarayan-redhat, will you PTAL? |
|
🤖 Wed Sep 02 19:44:11 - Prow CI generated the docs preview: https://119252--ocpdocs-pr.netlify.app/openshift-enterprise/latest/disconnected/about-installing-oc-mirror-v2.html |
|
@hongkailiu: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@ all We can probably try adding a note in docs if this needs to be clarified. |
Use the hyphenated oc-mirror binary name for the v2 --help verification command, consistent with other oc-mirror v2 docs.
Version(s):
Issue:
Link to docs preview:
QE review:
Additional information: