Skip to content

Comments

Add documentation for BuildDefaults and BuildOverrides#1563

Merged
adellape merged 1 commit intoopenshift:masterfrom
csrwng:build_defaults_overrides
Feb 18, 2016
Merged

Add documentation for BuildDefaults and BuildOverrides#1563
adellape merged 1 commit intoopenshift:masterfrom
csrwng:build_defaults_overrides

Conversation

@csrwng
Copy link

@csrwng csrwng commented Feb 9, 2016

Documents the build defaults and overrides plugins

@csrwng
Copy link
Author

csrwng commented Feb 9, 2016

@bparees ptal

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

environment

@csrwng
Copy link
Author

csrwng commented Feb 9, 2016

Thx @bparees, added a commit to address your comments.

@bparees
Copy link
Contributor

bparees commented Feb 9, 2016

lgtm

@csrwng
Copy link
Author

csrwng commented Feb 9, 2016

@adellape ptal

@adellape adellape added this to the OSE Future milestone Feb 11, 2016
@adellape
Copy link
Contributor

@csrwng Can you squash this? Otherwise, LGTM, thanks!

@adellape
Copy link
Contributor

@csrwng Slated for OSE 3.2?

@bparees
Copy link
Contributor

bparees commented Feb 11, 2016

@adellape yes, this is in 3.2

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be "BuildOverrides" not "BuildDefaults"

@csrwng csrwng force-pushed the build_defaults_overrides branch from cd96550 to 2e73453 Compare February 16, 2016 14:19
@csrwng
Copy link
Author

csrwng commented Feb 16, 2016

@adellape squashed and fixed latest comments.

@csrwng csrwng force-pushed the build_defaults_overrides branch from 2e73453 to 26f31f4 Compare February 16, 2016 20:09
adellape added a commit that referenced this pull request Feb 18, 2016
Add documentation for BuildDefaults and BuildOverrides
@adellape adellape merged commit f04d82b into openshift:master Feb 18, 2016
@adellape
Copy link
Contributor

revhistory note to be provided in follow-up PR.

@csrwng csrwng deleted the build_defaults_overrides branch February 22, 2016 13:46
@adellape adellape changed the title Add documentation for BuildDefaults and BuildOverrides Bug 1307212: Add documentation for BuildDefaults and BuildOverrides Mar 18, 2016
@adellape adellape changed the title Bug 1307212: Add documentation for BuildDefaults and BuildOverrides Add documentation for BuildDefaults and BuildOverrides Mar 18, 2016
@adellape adellape modified the milestones: OSE 3.2, Future Release Apr 22, 2016
@adellape adellape modified the milestones: OSE 3.2, Staging, OSE 3.2 (Picked) May 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants