Skip to content

Comments

Bug 1307212: Follow-up to BuildDefaults/BuildOverrides (PR#1563)#1766

Merged
adellape merged 1 commit intoopenshift:masterfrom
adellape:globalproxy
Mar 22, 2016
Merged

Bug 1307212: Follow-up to BuildDefaults/BuildOverrides (PR#1563)#1766
adellape merged 1 commit intoopenshift:masterfrom
adellape:globalproxy

Conversation

@adellape
Copy link
Contributor

https://bugzilla.redhat.com/show_bug.cgi?id=1307212

Follow-up to #1563.

  • General edits
  • Title change
  • Moves the topic from "Cluster Administration" to "Installation & Configuration". It felt closer to something that a cluster admin would want to consider during initial/early setup (Install & Config guide), versus a day to day task (Cluster Admin guide)

@csrwng for tech review
@openshift/team-documentation for peer review

Pretty build:

http://file.rdu.redhat.com/~adellape/031816/globalproxy/install_config/build_defaults_overrides.html

@adellape adellape added this to the Future Release milestone Mar 18, 2016
@adellape adellape added tech_review peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Mar 18, 2016
@adellape adellape changed the title Follow-up to BuildDefaults/BuildOverrides (PR#1563) Bug 1307212: Follow-up to BuildDefaults/BuildOverrides (PR#1563) Mar 18, 2016
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/populate these settings into any build configuration./use these settings in any build./

The settings from the plugin config don't get set on the build config or builds, they actually only get used during the build. That way, at any time you can change your global config and re-run builds from those builds/build configs and get the new settings.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, whoops. Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed per above suggestion, and added this paragraph that follows for clarification:

The settings from these plug-ins are not set in the build configurations or
builds themselves, but rather are only used during the build process. This
allows administrators to change the global configuration at any time, and any
builds that are re-run from existing build configurations or builds will get the
new settings.

@csrwng
Copy link

csrwng commented Mar 18, 2016

Just one comment, otherwise, LGTM

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/allows overriding a setting/allows the overriding of a setting
Alternatively (maybe better):
"allows a setting in a build to be overridden"

Maybe? Just seems like awkward phrasing to me.

@ahardin-rh
Copy link
Contributor

@adellape just one nit, which you can take or leave. Otherwise, LGTM!

@adellape adellape removed peer-review-in-progress Signifies that the peer review team is reviewing this PR tech_review labels Mar 22, 2016
@adellape
Copy link
Contributor Author

Updated per comments.

adellape added a commit that referenced this pull request Mar 22, 2016
Bug 1307212: Follow-up to BuildDefaults/BuildOverrides (PR#1563)
@adellape adellape merged commit d91989b into openshift:master Mar 22, 2016
@adellape adellape deleted the globalproxy branch April 14, 2016 17:18
@adellape adellape modified the milestones: OSE 3.2, Future Release May 3, 2016
@adellape
Copy link
Contributor Author

adellape commented May 3, 2016

[rev_history]
|link:../install_config/build_defaults_overrides.html[Configuring Global Build Defaults and Overrides]
|New topic convering the new *BuildDefaults* and *BuildOverrides* admission control plug-ins.
%

@adellape adellape modified the milestones: OSE 3.2, Staging, OSE 3.2 (Picked) May 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants