Bug 1307212: Follow-up to BuildDefaults/BuildOverrides (PR#1563)#1766
Bug 1307212: Follow-up to BuildDefaults/BuildOverrides (PR#1563)#1766adellape merged 1 commit intoopenshift:masterfrom
Conversation
There was a problem hiding this comment.
s/populate these settings into any build configuration./use these settings in any build./
The settings from the plugin config don't get set on the build config or builds, they actually only get used during the build. That way, at any time you can change your global config and re-run builds from those builds/build configs and get the new settings.
There was a problem hiding this comment.
Ah, whoops. Thanks!
There was a problem hiding this comment.
Fixed per above suggestion, and added this paragraph that follows for clarification:
The settings from these plug-ins are not set in the build configurations or
builds themselves, but rather are only used during the build process. This
allows administrators to change the global configuration at any time, and any
builds that are re-run from existing build configurations or builds will get the
new settings.
|
Just one comment, otherwise, LGTM |
There was a problem hiding this comment.
s/allows overriding a setting/allows the overriding of a setting
Alternatively (maybe better):
"allows a setting in a build to be overridden"
Maybe? Just seems like awkward phrasing to me.
|
@adellape just one nit, which you can take or leave. Otherwise, LGTM! |
|
Updated per comments. |
Bug 1307212: Follow-up to BuildDefaults/BuildOverrides (PR#1563)
|
[rev_history] |
https://bugzilla.redhat.com/show_bug.cgi?id=1307212
Follow-up to #1563.
@csrwng for tech review
@openshift/team-documentation for peer review
Pretty build:
http://file.rdu.redhat.com/~adellape/031816/globalproxy/install_config/build_defaults_overrides.html