Skip to content

Comments

add image policy documentation#2647

Merged
ahardin-rh merged 1 commit intoopenshift:masterfrom
deads2k:image-policy
Aug 22, 2016
Merged

add image policy documentation#2647
ahardin-rh merged 1 commit intoopenshift:masterfrom
deads2k:image-policy

Conversation

@deads2k
Copy link
Contributor

@deads2k deads2k commented Aug 12, 2016

Adds documentation explaining how to use and test the ImagePolicy admission plugin.

@simon3z fyi
@smarterclayton beta or tech preview? What's the distinction again?

@simon3z
Copy link

simon3z commented Aug 12, 2016

cc @moolitayer

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It allows you to control? (otherwise 1. below does not read well)

@moolitayer
Copy link

moolitayer commented Aug 14, 2016

@simon3z I will create a ManageIQ upstream doc linking here.

@simon3z
Copy link

simon3z commented Aug 15, 2016

@simon3z I will create a ManageIQ upstream doc linking here.

@moolitayer I suppose this will be published somewhere in https://docs.openshift.com/enterprise/latest/welcome/index.html
cc @deads2k

@deads2k
Copy link
Contributor Author

deads2k commented Aug 15, 2016

@adellape Is there a tag I should use for 3.3 items? I've got a few.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the plugin the above

@deads2k
Copy link
Contributor Author

deads2k commented Aug 19, 2016

Comments addressed.

@moolitayer @simon3z take note. We changed the API slightly since 3.3 had not shipped. I've updated the examples to match.

@deads2k
Copy link
Contributor Author

deads2k commented Aug 19, 2016

@ahardin-rh another for 1.3/3.3

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/admission plugin/Admission Plug-in

@ahardin-rh ahardin-rh added this to the Future Release milestone Aug 22, 2016
@ahardin-rh ahardin-rh self-assigned this Aug 22, 2016
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest rewording:
For example, use the information above, then test like this:

@ahardin-rh
Copy link
Contributor

@deads2k Thanks! A few comments from me.

Should this be included in Dedicated as well? If so, I will adjust my labels accordingly. Thanks again!

@deads2k
Copy link
Contributor Author

deads2k commented Aug 22, 2016

Should this be included in Dedicated as well? If so, I will adjust my labels accordingly. Thanks again!

No, it shouldn't, though it does raise an interesting question about whether and how someone in dedicated would want to control this. @smarterclayton something for us to consider.

@deads2k
Copy link
Contributor Author

deads2k commented Aug 22, 2016

Comments addressed.

@ahardin-rh
Copy link
Contributor

@deads2k Thanks! Can you please give it a squash? 🙇

@deads2k
Copy link
Contributor Author

deads2k commented Aug 22, 2016

@deads2k Thanks! Can you please give it a squash?

done

@ahardin-rh ahardin-rh merged commit 27c14ee into openshift:master Aug 22, 2016
@ahardin-rh
Copy link
Contributor

[rev_history]
|xref:../admin_guide/image_policy.adoc#admin-guide-image-policy[Image Policy]
|New topic about controlling which images are allowed to run on your cluster using the ImagePolicy admission plug-in.
%

@vikram-redhat vikram-redhat modified the milestones: OCP 3.3 GA, TEMP Oct 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants