add rslave propagation mode for volume mounts#3356
Merged
ahardin-rh merged 1 commit intoopenshift:masterfrom Dec 12, 2016
Merged
add rslave propagation mode for volume mounts#3356ahardin-rh merged 1 commit intoopenshift:masterfrom
ahardin-rh merged 1 commit intoopenshift:masterfrom
Conversation
Author
|
@adellape also see this conversation openshift/origin#10571 (comment) about support statements for < docker 1.10. If we need to call that out in this guide let me know. |
Author
|
@ahardin-rh mind reviewing? This is for a 3.4 blocker bug |
Contributor
|
@pweil- LGTM. I will create a follow-up PR noting that rslave mode will only work if the Docker version is 1.10 and later and a Red Hat distro. |
Contributor
|
No revision history needed (shows up in Origin only) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference: openshift/origin#11601 and openshift/origin#10571
Use rslave mode for volume mount when running origin in a container
@pmorie @derekwaynecarr
@adellape