Skip to content

Conversation

@jldohmann
Copy link
Contributor

@jldohmann jldohmann commented Jul 20, 2022

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 20, 2022
@jldohmann
Copy link
Contributor Author

@mike-nguyen PTAL for QE ack, thank you!

@mike-nguyen
Copy link
Member

I don't think customers can browser rhcos.mirror.openshift.com. It is a redirector to the S3 backend so customers will need to know the exact URL to the image they are looking for.

@jldohmann jldohmann force-pushed the BZ2102230-rn branch 2 times, most recently from 19ce228 to 3e22fc7 Compare July 20, 2022 19:58
@jldohmann
Copy link
Contributor Author

@mike-nguyen good point 😅 I've updated the text and included a link to the relevant doc, could you PTAL again?

273ed5c..19ce228
19ce228..3e22fc7

Copy link
Member

@travier travier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as Mike but otherwise LGTM

@jldohmann
Copy link
Contributor Author

3e22fc7..db38682 implement feedback

@bergerhoffer bergerhoffer added the peer-review-done Signifies that the peer review team has reviewed this PR label Jul 21, 2022
@jldohmann
Copy link
Contributor Author

db38682..1d9ee4d implement peer review feedback

@opayne1
Copy link
Contributor

opayne1 commented Jul 21, 2022

lgtm!

@opayne1 opayne1 merged commit 571ab93 into openshift:enterprise-4.11 Jul 21, 2022
@jldohmann jldohmann deleted the BZ2102230-rn branch July 21, 2022 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.11 peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants