Skip to content

Conversation

@jldohmann
Copy link
Contributor

@jldohmann jldohmann commented Jul 20, 2022

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 20, 2022
@jldohmann
Copy link
Contributor Author

@travier @mike-nguyen can y'all PTAL to make sure URLs are correct? Also, the BZ ticket says to backport to 4.8, should this PR apply to 4.8-4.10 as well? Just wanna check. Thanks!

@mike-nguyen
Copy link
Member

mike-nguyen commented Jul 20, 2022

I think this will apply all the way back to 4.6--possibly 4.5 depending on whether would break old installs.

Here is the PR for 4.6 and 4.7
openshift/installer#6138
openshift/installer#6139

The RHCOS team is planning on doing a boot image bump for 4.9 and 4.8 where the URL will be updated in the installer

@jldohmann
Copy link
Contributor Author

jldohmann commented Jul 20, 2022

@mike-nguyen thanks for the info, I'm thinking maybe separate PRs for those would be best if the installer PRs are not merged yet. If we cherrypicked this PR to 4.6-4.10 before the installer PRs are merged, customers won't have the correct information. Wdyt?

@GroceryBoyJr
Copy link
Contributor

@jldohmann @mike-nguyen I recommend different PR's for each release. If the cherrypick fails (likely), you have to do individual PR's for each failing release anyway.

Copy link
Contributor

@GroceryBoyJr GroceryBoyJr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM!

@mike-nguyen
Copy link
Member

Agreed with separate PRs. We'll just need to keep them in mind when the boot image bumps merge since they don't have a BZ directly tied to them.

@travier
Copy link
Member

travier commented Jul 21, 2022

For 4.11+, the installer will be released with this URL only, but for backports, we should include both URLs in the docs as older installers will keep using the previous one.

+1 for separate PRs that land when the installer changes land.

@opayne1 opayne1 added peer-review-done Signifies that the peer review team has reviewed this PR lgtm Indicates that a PR is ready to be merged. branch/enterprise-4.11 labels Jul 21, 2022
@opayne1 opayne1 added this to the Future Release milestone Jul 21, 2022
@opayne1 opayne1 merged commit fecef91 into openshift:main Jul 21, 2022
@opayne1
Copy link
Contributor

opayne1 commented Jul 21, 2022

/cherry-pick enterprise-4.11

@openshift-cherrypick-robot

@opayne1: new pull request created: #48103

In response to this:

/cherry-pick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.11 lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants