-
Notifications
You must be signed in to change notification settings - Fork 1.8k
BZ2102230: change rhcos redirector url #48037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@travier @mike-nguyen can y'all PTAL to make sure URLs are correct? Also, the BZ ticket says to backport to 4.8, should this PR apply to 4.8-4.10 as well? Just wanna check. Thanks! |
|
I think this will apply all the way back to 4.6--possibly 4.5 depending on whether would break old installs. Here is the PR for 4.6 and 4.7 The RHCOS team is planning on doing a boot image bump for 4.9 and 4.8 where the URL will be updated in the installer |
|
@mike-nguyen thanks for the info, I'm thinking maybe separate PRs for those would be best if the installer PRs are not merged yet. If we cherrypicked this PR to 4.6-4.10 before the installer PRs are merged, customers won't have the correct information. Wdyt? |
|
@jldohmann @mike-nguyen I recommend different PR's for each release. If the cherrypick fails (likely), you have to do individual PR's for each failing release anyway. |
GroceryBoyJr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/LGTM!
|
Agreed with separate PRs. We'll just need to keep them in mind when the boot image bumps merge since they don't have a BZ directly tied to them. |
|
For 4.11+, the installer will be released with this URL only, but for backports, we should include both URLs in the docs as older installers will keep using the previous one. +1 for separate PRs that land when the installer changes land. |
|
/cherry-pick enterprise-4.11 |
|
@opayne1: new pull request created: #48103 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Version(s): 4.11+
Issue: https://bugzilla.redhat.com/show_bug.cgi?id=2102230
Link to docs preview: http://file.rdu.redhat.com/jdohmann/BZ2102230/installing/install_config/configuring-firewall.html#configuring-firewall_configuring-firewall
Additional information: