Skip to content

Conversation

@jldohmann
Copy link
Contributor

@jldohmann jldohmann commented Aug 3, 2022

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 3, 2022
@jldohmann
Copy link
Contributor Author

@mike-nguyen PTAL for QE ack. This is a manual cherrypick of #48134 to 4.6

@mike-nguyen
Copy link
Member

This looks good to me, but we haven't made the the changes to 4.6 yet. We've worked our way back from 4.12 to 4.9. 4.8, 4.7, and 4.6 have not been done yet.

@jldohmann
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 3, 2022
Copy link
Contributor

@kelbrown20 kelbrown20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the peer review end, this LGTM!

@jldohmann
Copy link
Contributor Author

@mike-nguyen has the installer PR for this landed?

@mike-nguyen
Copy link
Member

@jldohmann looks like the PRs got closed because 4.6 and 4.7 are EOL.

@jldohmann
Copy link
Contributor Author

Thanks @mike-nguyen, I am going to go ahead and close this PR. I can reopen again if needed

@jldohmann jldohmann closed this Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants