Conversation
|
@eriknelson PTAL, based on openshift/ansible-service-broker#634. |
There was a problem hiding this comment.
@eriknelson This bit "explicitly if recognizes them" seems like a typo, but I wasn't sure what it should be. Maybe "explicitly if it recognizes them"?
There was a problem hiding this comment.
The original content had dh here, though in the OCP doc we've only mentioned the dockerhub type. Are either acceptable?
There was a problem hiding this comment.
There are two fields in a registry configuration, the type. In this case, only dockerhub is acceptable. The name defaults to dh, but this can be an arbitrary value. dh, or another relatively short name is preferred, as it's used as part of the ServiceClass label, which can become quite long.
|
Alternate preview from a different branch where I'm trying out splitting http://file.rdu.redhat.com/~adellape/030618/oab_auth/install_config/oab/oab_proxy.html |
There was a problem hiding this comment.
Your doc should contain PR https://github.com/openshift/ansible-service-broker/pull/806/files
eriknelson
left a comment
There was a problem hiding this comment.
Looks good and correct to me, although I think there may be a few things missing from this document that I think should be added (and I probably owe).
- WRT: Configuring the broker for a proxy, the upstream documentation is written from a developer's perspective which are the steps required to manually configure a broker.
I'm assuming most consumers of these docs will be using openshift-ansible, which we have patched so the broker deployment inherits the cluster-wide proxy settings.
We should split the section into something like: Configuring the broker with a proxy using openshift-ansible, and then Configuring the broker manually.
- Another default behavior for
openshift-ansibleis that it will generate theNO_PROXYlist, and include theclusterNetworkCIDRand theserviceNetworkCIDR. It's important these are added if configuring manually. I will follow up and confirm the advisedNO_PROXYlist today.
|
@eriknelson @chengzhang1016 Done some rearranging / changes based on latest feedback: |
|
@adellape New docs look good, that's the correct NO_PROXY 👍, ACK. |
xref: https://trello.com/c/cGffDEif
Preview:
http://file.rdu.redhat.com/~adellape/030618/oab_proxy/install_config/oab_broker_configuration.html#configuring-oab-proxy