-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OBSDOCS-1749: Add section about uiplugin in installing logging #92388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@theashiot: This pull request references OBSDOCS-1749 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Skipping CI for Draft Pull Request. |
|
/test all |
|
@theashiot: This pull request references OBSDOCS-1749 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
| * You have installed the Loki operator. | ||
|
|
||
| .Procedure | ||
| . Install the {coo-full}. For more information, see xref:../../../observability/cluster_observability_operator/cluster-observability-operator-overview.adoc#cluster-observability-operator-overview[Cluster Observability Operator]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not linking to the correct page. The page we want is https://92388--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/cluster_observability_operator/installing-the-cluster-observability-operator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
| .Procedure | ||
| . Install the {coo-full}. For more information, see xref:../../../observability/cluster_observability_operator/cluster-observability-operator-overview.adoc#cluster-observability-operator-overview[Cluster Observability Operator]. | ||
|
|
||
| . Create an instance of the `UIPlugin` resource. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| . Create an instance of the `UIPlugin` resource. | |
| . Navigate to the `Installed Operators` page. Select the `ClusterObservabilityOperator` under the Provided APIs find the `UIPlugin` resource and click Create Instance. | |
| . Select YAML view, and then use the following template to create a `UIPlugin` CR: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
| <1> Set `name` to `logging`. | ||
| <2> Set `type` to `Logging`. | ||
| <3> `name` must match the name of your LokiStack instance. | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| . Click Create. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a tip that if LokiStack is installed in a namespace other than openshift-logging they can also set namespace in the lokistack refrence
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
| <2> Set `type` to `Logging`. | ||
| <3> `name` must match the name of your LokiStack instance. | ||
|
|
||
| . Navigate to the Observe → Logs panel where you can run LogQL queries. You can aslo query Logs for individual pods from the pods view *Aggregated Logs* tab. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you put this under ".Verification"
- Wait a few minutes for a pop-up to show on the top right of the screen to refresh
- Navigate...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For CLI instructions they should be the same but instead of user navigating in the console they only need to create a YAML resource and then apply that resource with oc apply -f similar to who we wrote for the other CLI instructions
|
Thanks, @JoaoBraveCoding for the review! I've made the required changes and also added steps for CLI. |
|
@theashiot: This pull request references OBSDOCS-1749 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
| * You have administrator permissions. | ||
| * You installed the {oc-first}. | ||
| * You installed and configured {loki-op}. | ||
| * You have created the `openshift-logging` namespace. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| * You have created the `openshift-logging` namespace. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
| . Refresh the page when a pop-up message instructs you to do so. | ||
| . Navigate to the Observe → Logs panel where you can run LogQL queries. You can aslo query Logs for individual pods from the pods view *Aggregated Logs* tab. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| . Refresh the page when a pop-up message instructs you to do so. | |
| . Navigate to the Observe → Logs panel where you can run LogQL queries. You can aslo query Logs for individual pods from the pods view *Aggregated Logs* tab. | |
| . Refresh the page when a pop-up message instructs you to do so. | |
| . Navigate to the Observe → Logs panel where you can run LogQL queries. You can also query Logs for individual pods from the pods view *Aggregated Logs* tab. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch, fixed!
| ==== | ||
| If you did not install LokiStack in the `openshift-logging` namespace, set the LokiStack namespace under the `lokiStack` configuration. | ||
| ==== | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
| * Verify the installation by running the following command: | ||
| + | ||
| [source,terminal] | ||
| ---- | ||
| $ oc get pods -n openshift-logging | ||
| ---- | ||
| + | ||
| .Example output | ||
| [source,terminal] | ||
| ---- | ||
| $ oc get pods -n openshift-logging | ||
| NAME READY STATUS RESTARTS AGE | ||
| cluster-logging-operator-56764d8c76-7m9kg 1/1 Running 0 19m | ||
| logging-loki-compactor-0 1/1 Running 0 10m | ||
| logging-loki-distributor-657647b49b-2hxwl 1/1 Running 0 10m | ||
| logging-loki-distributor-657647b49b-qdnpf 1/1 Running 0 10m | ||
| logging-loki-gateway-79c497c9-69mqs 2/2 Running 0 10m | ||
| logging-loki-gateway-79c497c9-hd9w5 2/2 Running 0 10m | ||
| logging-loki-index-gateway-0 1/1 Running 0 10m | ||
| logging-loki-index-gateway-1 1/1 Running 0 10m | ||
| logging-loki-ingester-0 1/1 Running 0 10m | ||
| logging-loki-ingester-1 1/1 Running 0 9m38s | ||
| logging-loki-querier-59c966d69c-ggjlg 1/1 Running 0 10m | ||
| logging-loki-querier-59c966d69c-n6c2g 1/1 Running 0 10m | ||
| logging-loki-query-frontend-bc86757-8qzwd 1/1 Running 0 10m | ||
| logging-loki-query-frontend-bc86757-kswxk 1/1 Running 0 10m | ||
| logging-loki-ruler-0 1/1 Running 0 10m | ||
| logging-loki-ruler-1 1/1 Running 0 10m | ||
|
|
||
| ---- | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| * Verify the installation by running the following command: | |
| + | |
| [source,terminal] | |
| ---- | |
| $ oc get pods -n openshift-logging | |
| ---- | |
| + | |
| .Example output | |
| [source,terminal] | |
| ---- | |
| $ oc get pods -n openshift-logging | |
| NAME READY STATUS RESTARTS AGE | |
| cluster-logging-operator-56764d8c76-7m9kg 1/1 Running 0 19m | |
| logging-loki-compactor-0 1/1 Running 0 10m | |
| logging-loki-distributor-657647b49b-2hxwl 1/1 Running 0 10m | |
| logging-loki-distributor-657647b49b-qdnpf 1/1 Running 0 10m | |
| logging-loki-gateway-79c497c9-69mqs 2/2 Running 0 10m | |
| logging-loki-gateway-79c497c9-hd9w5 2/2 Running 0 10m | |
| logging-loki-index-gateway-0 1/1 Running 0 10m | |
| logging-loki-index-gateway-1 1/1 Running 0 10m | |
| logging-loki-ingester-0 1/1 Running 0 10m | |
| logging-loki-ingester-1 1/1 Running 0 9m38s | |
| logging-loki-querier-59c966d69c-ggjlg 1/1 Running 0 10m | |
| logging-loki-querier-59c966d69c-n6c2g 1/1 Running 0 10m | |
| logging-loki-query-frontend-bc86757-8qzwd 1/1 Running 0 10m | |
| logging-loki-query-frontend-bc86757-kswxk 1/1 Running 0 10m | |
| logging-loki-ruler-0 1/1 Running 0 10m | |
| logging-loki-ruler-1 1/1 Running 0 10m | |
| ---- | |
| . Access the OpenShift Container Platform web console and refresh the page if a pop-up message instructs you to do so. | |
| . Navigate to the Observe → Logs panel where you can run LogQL queries. You can also query Logs for individual pods from the pods view *Aggregated Logs* tab. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
| Install the Logging UI plug-in by using the web console to visualize logs. | ||
|
|
||
| .Prerequisites | ||
| * You have installed the Loki operator. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| * You have installed the Loki operator. | |
| * You have administrator permissions. | |
| * You have access to the OpenShift Container Platform web console. | |
| * You installed and configured {loki-op}. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
|
Thanks, @JoaoBraveCoding for approving the changes! best, |
|
For QE review, @anpingli , @kabirbhartiRH, @QiaolingTang , can someone please review the docs? thanks, |
| <2> Set `type` to `Logging`. | ||
| <3> `name` must match the name of your LokiStack instance. | ||
| + | ||
| [NOTE] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't support deploy lokistack in the other namespace expect for openshift-logging . @JoaoBraveCoding Can you confirm if we can enable it now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know there was a customer case that required us to add the namespace. But in regards to support I'm not I'll check with @xperimental during the daily today
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed it with @xperimental and with 6.x there isn't anything blocking users from installing logging on a different namespace
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No idea if there is limitation to deploy the logging in the other namespace. let me confirm this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
@theashiot: This pull request references OBSDOCS-1749 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Thanks, @JoaoBraveCoding, @anpingli for the reveiw! |
|
/label peer-review-needed |
lahinson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! I made a few suggestions for your consideration.
| :_mod-docs-content-type: PROCEDURE | ||
|
|
||
| [id="installing-the-logging-ui-plug-in-cli_{context}"] | ||
| = Installing the Logging UI plug-in by using the CLI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Supplementary Style Guide: https://redhat-documentation.github.io/supplementary-style-guide/#plug-in
| = Installing the Logging UI plug-in by using the CLI | |
| = Installing the Logging UI plugin by using the CLI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
| [id="installing-the-logging-ui-plug-in-cli_{context}"] | ||
| = Installing the Logging UI plug-in by using the CLI | ||
|
|
||
| Install the Logging UI plug-in by using the comman-line interfatce (CLI) to visualize logs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Install the Logging UI plug-in by using the comman-line interfatce (CLI) to visualize logs. | |
| Install the Logging UI plugin by using the command-line interface (CLI) so that you can visualize logs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
| ---- | ||
| <1> Set `name` to `logging`. | ||
| <2> Set `type` to `Logging`. | ||
| <3> `name` must match the name of your LokiStack instance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <3> `name` must match the name of your LokiStack instance. | |
| <3> The `name` value must match the name of your LokiStack instance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
|
|
||
| .Verification | ||
|
|
||
| . Access the OpenShift Container Platform web console and refresh the page if a pop-up message instructs you to do so. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| . Access the OpenShift Container Platform web console and refresh the page if a pop-up message instructs you to do so. | |
| . Access the {product-title} web console, and refresh the page if a pop-up message instructs you to do so. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
| .Verification | ||
|
|
||
| . Access the OpenShift Container Platform web console and refresh the page if a pop-up message instructs you to do so. | ||
| . Navigate to the Observe → Logs panel where you can run LogQL queries. You can also query Logs for individual pods from the pods view *Aggregated Logs* tab. No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| . Navigate to the Observe → Logs panel where you can run LogQL queries. You can also query Logs for individual pods from the pods view *Aggregated Logs* tab. | |
| . Navigate to the *Observe → Logs* panel, where you can run LogQL queries. You can also query logs for individual pods from the *Aggregated Logs* tab of a specific pod. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
|
|
||
| .Prerequisites | ||
| * You have administrator permissions. | ||
| * You have access to the OpenShift Container Platform web console. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| * You have access to the OpenShift Container Platform web console. | |
| * You have access to the {product-title} web console. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
| * You installed and configured {loki-op}. | ||
|
|
||
| .Procedure | ||
| . Install the {coo-full}. For more information, see link:https://docs.redhat.com/en/documentation/openshift_container_platform/4.18/html/cluster_observability_operator/installing-cluster-observability-operators[Cluster Observability Operator]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| . Install the {coo-full}. For more information, see link:https://docs.redhat.com/en/documentation/openshift_container_platform/4.18/html/cluster_observability_operator/installing-cluster-observability-operators[Cluster Observability Operator]. | |
| . Install the {coo-full}. For more information, see link:https://docs.redhat.com/en/documentation/openshift_container_platform/4.18/html/cluster_observability_operator/installing-cluster-observability-operators[Installing the Cluster Observability Operator]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
| .Procedure | ||
| . Install the {coo-full}. For more information, see link:https://docs.redhat.com/en/documentation/openshift_container_platform/4.18/html/cluster_observability_operator/installing-cluster-observability-operators[Cluster Observability Operator]. | ||
|
|
||
| . Navigate to the *Installed Operators* page. Select the *ClusterObservabilityOperator* under *Provided APIs*, find the `UIPlugin` resource and click *Create Instance*. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| . Navigate to the *Installed Operators* page. Select the *ClusterObservabilityOperator* under *Provided APIs*, find the `UIPlugin` resource and click *Create Instance*. | |
| . Navigate to the *Installed Operators* page. Under *Provided APIs*, select *ClusterObservabilityOperator*. Find the `UIPlugin` resource and click *Create Instance*. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
| ---- | ||
| <1> Set `name` to `logging`. | ||
| <2> Set `type` to `Logging`. | ||
| <3> `name` must match the name of your LokiStack instance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <3> `name` must match the name of your LokiStack instance. | |
| <3> The `name` value must match the name of your LokiStack instance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
| .Verification | ||
|
|
||
| . Refresh the page when a pop-up message instructs you to do so. | ||
| . Navigate to the Observe → Logs panel where you can run LogQL queries. You can also query Logs for individual pods from the pods view *Aggregated Logs* tab. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| . Navigate to the Observe → Logs panel where you can run LogQL queries. You can also query Logs for individual pods from the pods view *Aggregated Logs* tab. | |
| . Navigate to the *Observe → Logs* panel, where you can run LogQL queries. You can also query logs for individual pods from the *Aggregated Logs* tab of a specific pod. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
|
New changes are detected. LGTM label has been removed. |
|
@theashiot: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@theashiot: This pull request references OBSDOCS-1749 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@theashiot: This pull request references OBSDOCS-1749 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/label merge-review-needed |
| * You installed and configured {loki-op}. | ||
|
|
||
| .Procedure | ||
| . Install the {coo-full}. For more information, see link:https://docs.redhat.com/en/documentation/openshift_container_platform/4.18/html/cluster_observability_operator/installing-cluster-observability-operators[Installing the Cluster Observability Operator]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be an xref?
|
/cherry-pick enterprise-4.17 |
|
/cherry-pick enterprise-4.16 |
|
@stevsmit: new pull request created: #93780 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@stevsmit: #92388 failed to apply on top of branch "enterprise-4.16": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Version(s): 4.18, 4.17, 4.16
Issue: https://issues.redhat.com/browse/OBSDOCS-1749
Link to docs preview:
QE review:
Additional information: