OBSDOCS-1982: Transfer UIPlugin content to standalone #94438
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@theashiot: This pull request references OBSDOCS-1982 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
size/L
|
🤖 Fri Jul 18 05:42:15 - Prow CI generated the docs preview: https://94438--ocpdocs-pr.netlify.app/openshift-logging/latest/installing/installing-logging.html |
|
@theashiot: This pull request references OBSDOCS-1982 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
gabriel-rh
left a comment
gabriel-rh
left a comment
There was a problem hiding this comment.
lgtm - just a few comments
| @@ -0,0 +1,56 @@ | |||
| // Module included in the following assemblies: | |||
| // | |||
| // * observability/logging/logging-6.2/6x-cluster-logging-deploying-6.2.adoc | |||
There was a problem hiding this comment.
these comments need to be updated at some stage, but there are a lot, so maybe use a separate PR if needed
| * You installed and configured {loki-op}. | ||
|
|
||
| .Procedure | ||
| . Install the {coo-full}. For more information, see link:https://docs.redhat.com/en/documentation/openshift_container_platform/4.18/html/cluster_observability_operator/installing-cluster-observability-operators[Installing the Cluster Observability Operator]. |
There was a problem hiding this comment.
maybe point at /latest instead of explicit /4.18
There was a problem hiding this comment.
can you help me with this? I couldn't find an attribute defining the current release.
There was a problem hiding this comment.
I think using /latest/ will always be redirected to the most recent version, so currently it will go to 4.18, next week it will point to 4.19
| type: Logging # <2> | ||
| logging: | ||
| lokiStack: | ||
| name: logging-loki # <3> |
There was a problem hiding this comment.
need to update with schema
| [id="installing-the-logging-ui-plugin-cli_{context}"] | ||
| = Installing the Logging UI plugin by using the CLI | ||
|
|
||
| Install the Logging UI plugin by using the command-line interface (CLI) so that you can visualize logs. |
There was a problem hiding this comment.
it is called "logging UI plugin" in the COO docs - I'm not sure I agree, but it might be better to be consistent and use lower case here as well
| type: Logging # <2> | ||
| logging: | ||
| lokiStack: | ||
| name: logging-loki # <3> |
There was a problem hiding this comment.
same comment about schema here
|
Thanks, @gabriel-rh for the review! I've made the required changes and added a question inline. Can you please have another look? best, |
|
@theashiot: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Hi @gabriel-rh i've made all the required changes. can you please have another look? best, |
gabriel-rh
merged commit 17d4075
into
openshift:standalone-logging-docs-main
|
/cherrypick standalone-logging-docs-6.3 |
gabriel-rh
added
peer-review-done
|
/cherrypick standalone-logging-docs-6.2 |
|
/cherrypick standalone-logging-docs-6.1 |
|
/cherrypick standalone-logging-docs-6.0 |
|
@gabriel-rh: new pull request created: #96519 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@gabriel-rh: new pull request created: #96520 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@gabriel-rh: new pull request created: #96521 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@gabriel-rh: new pull request created: #96522 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
5 participants
Version(s): 6.0+
Issue: https://issues.redhat.com/browse/OBSDOCS-1982
Link to docs preview:
QE review:
Additional information: The original PR in non-standalone docs: #92388