Conversation
Protect access of the original writer. Panics if anything has wrote into the original writer or the writer is hijacked when times out.
The Pop method should allow a caller to requeue an item while under the fifo lock, to avoid races on deletes.
…ed as read-only. Send a node event when this happens and hint to the administrator about the remediation.
Previously it was trying to use a nil pod variable if error was returned from the pod update call. (note that the rest of 26680 is unit test related, and not picked here)
|
[test] |
|
With respect to the origin master HEAD (e5178ec): Only this one is not cherry-picked yet, the rest from Eric'c list is:
|
|
Evaluated for origin test up to b6e8f68 |
|
25308 isn't a clean cherry-pick because the history command has changed after 1.3. But we probably could massage it into our code. |
|
continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/8220/) |
|
All the picks look good to me. The pick for 29672 is good, but I could not see what underlying issue it fixed, seemed like a change to just code hygiene since there was no reference to a material panic it prevented. |
|
$ goroutine 111 [running]: |
|
So "UPSTREAM: 29743: Fix race condition found in JitterUntil" is the culprit |
|
Putting the Works for containerized world. So either put back the call or skip the cherry-pick as @derekwaynecarr suggests. |
|
Isn't this actually exposing a real issue though? /cc @liggitt |
|
@ingvagabund Given where we are at in the release cycle think putting it back in makes sense, but imho we need to re-eval in the next cycle issues we are actually glossing over. |
|
@timothysc - I agree it could cover a real issue, I have decided to carry a patch that keeps handle crash, and we can open an issue to evaluate that carry after release. see #10541 |
|
closing in favor of #10541 |
5 participants
Cherry picks of
for #9790 (comment)
cc @smarterclayton @eparis @timothysc @sttts @ingvagabund @derekwaynecarr @pmorie