Skip to content

Clear conntrack entries for externalIPs #22345

Merged
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
JacobTanenbaum:ClearConntrack
Mar 30, 2019
Merged

Clear conntrack entries for externalIPs #22345
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
JacobTanenbaum:ClearConntrack

Conversation

@JacobTanenbaum
Copy link
Copy Markdown
Contributor

@JacobTanenbaum JacobTanenbaum commented Mar 18, 2019

This brings in two Upstream commits to clear conntrack entries for externalIP addresses

fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=1632192
https://bugzilla.redhat.com/show_bug.cgi?id=1679260

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 18, 2019
@dcbw
Copy link
Copy Markdown
Contributor

dcbw commented Mar 18, 2019

@JacobTanenbaum commits need a ':' between PR # and the commit message, says the travis test. After that:
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 18, 2019
@JacobTanenbaum
UPSTREAM: 73323: Clear conntrack entries for externalIP and LoadBalan…
32ea306 
…cer IP

When an endpoint is deleted, the conntrack entries are cleared for
clusterIP but not for externalIP of the service. This change adds
that step.
@JacobTanenbaum
UPSTREAM: 75265: Clear conntrack entries on 0 -> 1 endpoint transitio…
289e5cf 
…n with externalIPs

As part of the endpoint creation process when going from 0 -> 1 conntrack entries
are cleared. This is to prevent an existing conntrack entry from preventing traffic
to the service. Currently the system ignores the existance of the services external IP
addresses, which exposes that errant behavior

This adds the externalIP addresses of udp services to the list of conntrack entries that
get cleared. Allowing traffic to flow

Signed-off-by: Jacob Tanenbaum jtanenba@redhat.com
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 19, 2019
@dcbw
Copy link
Copy Markdown
Contributor

dcbw commented Mar 19, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 19, 2019
@dcbw
Copy link
Copy Markdown
Contributor

dcbw commented Mar 19, 2019

AWS install resource timeouts
/retest

@dcbw
Copy link
Copy Markdown
Contributor

dcbw commented Mar 19, 2019

still more AWS install resource timeouts
/retest

@JacobTanenbaum
Copy link
Copy Markdown
Contributor Author

JacobTanenbaum commented Mar 19, 2019

/retest

2 similar comments
@JacobTanenbaum
Copy link
Copy Markdown
Contributor Author

JacobTanenbaum commented Mar 19, 2019

/retest

@JacobTanenbaum
Copy link
Copy Markdown
Contributor Author

JacobTanenbaum commented Mar 20, 2019

/retest

@knobunc knobunc changed the title Clear conntrack entries for extrenalIPs Clear conntrack entries for externalIPs Mar 21, 2019
@knobunc
Copy link
Copy Markdown
Contributor

knobunc commented Mar 21, 2019

/approve

@knobunc
Copy link
Copy Markdown
Contributor

knobunc commented Mar 21, 2019

@derekwaynecarr can you approve this backport please? It's a udp conntrack fix.

@knobunc
Copy link
Copy Markdown
Contributor

knobunc commented Mar 25, 2019

@eparis can you approve this backport please? It's a udp conntrack fix.

@JacobTanenbaum
Copy link
Copy Markdown
Contributor Author

JacobTanenbaum commented Mar 26, 2019

@eparis @derekwaynecarr @smarterclayton PTAL could you approve this backport? It is a udp conntrack fix

@eparis
Copy link
Copy Markdown
Member

eparis commented Mar 30, 2019

/approve

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Mar 30, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dcbw, eparis, JacobTanenbaum, knobunc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 30, 2019
@openshift-merge-robot openshift-merge-robot merged commit eae8710 into openshift:master Mar 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danwinship danwinship Awaiting requested review from danwinship

@dcbw dcbw Awaiting requested review from dcbw

Assignees

@dcbw dcbw

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@JacobTanenbaum @dcbw @knobunc @eparis @openshift-ci-robot @openshift-merge-robot