Skip to content

Proxy /apis/ to kubernetes#8125

Closed
liggitt wants to merge 1 commit intoopenshift:masterfrom
liggitt:proxy-apis
Closed

Proxy /apis/ to kubernetes#8125
liggitt wants to merge 1 commit intoopenshift:masterfrom
liggitt:proxy-apis

Conversation

@liggitt
Copy link
Copy Markdown
Contributor

@liggitt liggitt commented Mar 18, 2016

When running against external kubernetes, /apis/ must be proxied to kube as well.

This may look different in the future when distributed API groups are working

@liggitt
Copy link
Copy Markdown
Contributor Author

liggitt commented Mar 18, 2016

@deads2k

@deads2k
Copy link
Copy Markdown
Contributor

deads2k commented Mar 18, 2016

Ah, you thought the same. He reported /version too?

merge for now, but we're going to have trouble. Eventually we'll be hosting things here too.

@paralin
Copy link
Copy Markdown
Contributor

paralin commented Mar 18, 2016

/version needs to be proxied too

@openshift-bot
Copy link
Copy Markdown
Contributor

continuous-integration/openshift-jenkins/merge Waiting: You are in the build queue at position: 2

@openshift-bot
Copy link
Copy Markdown
Contributor

Evaluated for origin merge up to a326baf

@openshift-bot
Copy link
Copy Markdown
Contributor

[Test]ing while waiting on the merge queue

@paralin
Copy link
Copy Markdown
Contributor

paralin commented Mar 18, 2016

... is it too much to ask for a mini-release for this? I'm going to need to deploy the images to dockerhub under our own namespace I think. It's a pretty big issue with such a simple fix.

@deads2k
Copy link
Copy Markdown
Contributor

deads2k commented Mar 18, 2016

... is it too much to ask for a mini-release for this? I'm going to need to deploy the images to dockerhub under our own namespace I think. It's a pretty big issue with such a simple fix.

We're working towards 1.2 and we keep latest up to date. it's also possible to pin a level based on sha.

@deads2k
Copy link
Copy Markdown
Contributor

deads2k commented Mar 18, 2016

@liggitt still lgtm, but please add a drift check for new, toplevel endpoints they add. I think starting a plain kube and hitting / ought to do it.

@paralin
Copy link
Copy Markdown
Contributor

paralin commented Mar 18, 2016

@deads2k Okay, I suppose the latest right now is stable enough to pin to just after this is merged & updated

@soltysh
Copy link
Copy Markdown
Contributor

soltysh commented Mar 22, 2016

@liggitt @deads2k is this good to go, I don't know what was the test failure, re-kicking test in the mean time.
[test]

@smarterclayton
Copy link
Copy Markdown
Contributor

[test]

@liggitt
Copy link
Copy Markdown
Contributor Author

liggitt commented Apr 27, 2016

I still have work to do here for kubectl to really work (swagger has to be stitched together somehow)

@openshift-bot
Copy link
Copy Markdown
Contributor

Evaluated for origin test up to a326baf

@openshift-bot
Copy link
Copy Markdown
Contributor

continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/3308/)

@liggitt
Copy link
Copy Markdown
Contributor Author

liggitt commented Aug 2, 2016

closing, will revisit with federated API group support

@liggitt liggitt closed this Aug 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants