OCPBUGS-98388: fix: TLS client cert rotation when no CA is configured

[machine424]

Make sure it doesn't panic AND doesn't perma-fail.

Point prometheus/common to a patched version (v0.62.0-based) that contains prometheus/common#908

Add TestClientTLSCertRotationWithoutCAFile (backported from prometheus#18727) to verify the fix end-to-end.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 5643cc50-6ce9-4b62-bcfc-e16a1a136855

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[machine424]

/jira cherrypick OCPBUGS-86251

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: machine424

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [machine424]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@machine424: Jira Issue OCPBUGS-86251 has been cloned as Jira Issue OCPBUGS-98388. Will retitle bug to link to clone.
/retitle OCPBUGS-98388: fix: TLS client cert rotation when no CA is configured

Details

In response to this:

/jira cherrypick OCPBUGS-86251

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@machine424: This pull request references Jira Issue OCPBUGS-98388, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.19.z) matches configured target version for branch (4.19.z)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
• release note text is set and does not match the template
• dependent bug Jira Issue OCPBUGS-86251 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent Jira Issue OCPBUGS-86251 targets the "4.20.z" version, which is one of the valid target versions: 4.20.0, 4.20.z
• bug has dependents

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Make sure it doesn't panic AND doesn't perma-fail.

Point prometheus/common to a patched version (v0.62.0-based) that contains prometheus/common#908

Add TestClientTLSCertRotationWithoutCAFile (backported from prometheus#18727) to verify the fix end-to-end.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[machine424]

/retest-required

[machine424]

/retest-required

[openshift-ci]

@machine424: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.