net edge: Bump build_root golang image ref #12084
Conversation
There was a problem hiding this comment.
There was some discussion about moving to 1.15 - can we not go to 1.15 here?
There was a problem hiding this comment.
We could jump to 1.15 here, I just noticed other components are still using 1.13 for the build_root. All of the other net edge components are on go 1.13 for build_root. Should this PR bump each of our components to go 1.15 in one go? (no pun intended)
There was a problem hiding this comment.
Actually, better idea, each of our components should be using rhel-8-release-golang-1.15-openshift-4.6 for build_root (to match the image build bases). Ill amend this PR to accomplish that.
xref https://coreos.slack.com/archives/CB95J6R4N/p1600696630055100
There was a problem hiding this comment.
@frobware I addressed your suggestion and re-pushed.
There was a problem hiding this comment.
Actually, better idea, each of our components should be using
rhel-8-release-golang-1.15-openshift-4.6forbuild_root(to match the image build bases). Ill amend this PR to accomplish that.
xref https://coreos.slack.com/archives/CB95J6R4N/p1600696630055100
/lgtm
Based on the slack conversation. Curious as to why we're the only component that currently references rhel-8-release-golang-1.15-openshift-4.6 .
There was a problem hiding this comment.
Based on the slack conversation. Curious as to why we're the only component that currently references
rhel-8-release-golang-1.15-openshift-4.6.
I too am confused and nervous to see that other components are referencing older Go images, but let's do the right thing.
/lgtm
bumps the build_root image ref to `rhel-8-release-golang-1.15-openshift-4.6` for router, ingress-operator, dns-operator, and coredns
sgreene570
force-pushed
the
coredns-unit-test-go-bump
branch
from
1a22884 to
6e2736f
Compare
sgreene570
changed the title
openshift-ci-robot
added
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: frobware, knobunc, Miciah, sgreene570 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@sgreene570: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
#12098 merged, should resolve CI errors |
|
@sgreene570: Updated the following 3 configmaps:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
8 participants
bumps the build_root image ref to
rhel-8-release-golang-1.15-openshift-4.6for the router, the ingress-operator, the dns-operator, and openshift/coredns. Context and art input https://coreos.slack.com/archives/CB95J6R4N/p1600696630055100