openshift-e2e-test: allow several upgrade targets#17778
openshift-e2e-test: allow several upgrade targets#17778openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Conversation
openshift-ci-robot
added
the
approved
vrutkovs
force-pushed
the
openshift-test-override-upgrade
branch
2 times, most recently
from
1e85e19 to
7df4f62
Compare
There was a problem hiding this comment.
Existing jobs like release-openshift-origin-installer-e2e-aws-upgrade-4.5-to-4.6-to-4.7-to-4.8-ci use:
TEST_SUITE=all IMAGE=RELEASE_IMAGES run-upgrade-testswith RELEASE_IMAGES replaced by $next_0,$next_1,$next_2. So maybe:
TARGET_RELEASES="${OPENSHIFT_UPGRADE_RELEASE_IMAGE_OVERRIDE}"
if [[ -f "${SHARED_DIR}/override-upgrade" ]]; then
TARGET_RELEASES="$(< "${SHARED_DIR}/override-releases")"
echo "Overriding upgrade target to ${TARGET_RELEASES[*]}"
fi
openshift-tests run-upgrade all \
--to-image "${TARGET_RELEASES}" \
...after updating origin to use --to-image the same way it currently uses IMAGE? Also, you'd need comma delimiters.
There was a problem hiding this comment.
Ah, run-upgrade-tests is just passing IMAGE through to --to-image, so no need to make any origin updates, it will already work with my suggestion.
There was a problem hiding this comment.
Oh, openshift-tests can already parse comma-delimited images? Nice, experimenting with it in #17732
There was a problem hiding this comment.
Cluster version in #17732 shows that comma-delimited release image works, updated the PR.
If `override-upgrade` file exists from shared dir, use this string as target release. `openshift-tests` accepts comma-separated list of releases. This would enable support for chained upgrades (4.x -> 4.x + 1 -> 4.x.2) within a single test
vrutkovs
force-pushed
the
openshift-test-override-upgrade
branch
from
7df4f62 to
62903c5
Compare
|
@vrutkovs: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vrutkovs, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@vrutkovs: Updated the
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
4 participants
If
override-upgradefile exists from shared dir, use this string astarget release.
openshift-testsaccepts comma-separated list of releases.The change is an interim solution until https://issues.redhat.com/browse/DPTP-1829 and https://issues.redhat.com/browse/DPTP-1644 are implemented, as this solution would still be limited by a single step timeout.
See #17732 for rehearsals with this PR