gather: support overriding image for disconnected environments#18414
gather: support overriding image for disconnected environments#18414openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Conversation
Prior to 4.8, must-gather tries to access the internet on disconnected environments. This changes adds support for the steps that run must-gather to support reading a must-gather-image.sh file from the shared directory to override which image to use. Baremetal disconnected will populate this file with the locally hosted image when working on a release older than 4.8.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: smarterclayton, stbenjam The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
| # without specifying an image to use. This looks at the release payload, | ||
| # and generates the pullspec for the must-gather in our mirrored | ||
| # registry. | ||
| OPENSHIFT_VERSION=\$(openshift_version) |
There was a problem hiding this comment.
What about sourcing ds-var.conf and using DS_OPENSHIFT_VERSION and DS_REGISTRY as in
There was a problem hiding this comment.
That's probably fine but maybe do it as a follow-up? Let's get 4.7 unblocked today. This gather bash works and we've been using it for more than a year in dev-scripts.
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@stbenjam: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@stbenjam: Updated the
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
5 participants
Prior to 4.8, must-gather tries to access the internet on disconnected
environments. This change adds support for the steps that run
must-gather to support reading a must-gather-image.sh file from the
shared directory to override which image to use.
Baremetal disconnected will populate this file with the locally hosted
image when working on a release older than 4.8.
4.7 jobs are failing on the gather steps: https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/periodic-ci-openshift-release-master-nightly-4.7-e2e-metal-ipi-ovn-ipv6/1390628216200237056