origin: use workflow's TEST_SKIPS for e2e-aws-proxy

[vrutkovs]

Several router tests are permafailing, and per https://bugzilla.redhat.com/show_bug.cgi?id=1882486 these are expected to be skipped.

The workflow was updated to set TEST_SKIPS, but origin test definition resets to empty skip list.

[sgreene570]

/lgtm

[vrutkovs]

Flakes

/retest

[wking]

/hold

I think these are intentional; holding while I gather context.

[wking]

#12375 gave origin the proxy tests, explicitly setting TEST_SKIPS empty, but with the tests optional: true. The idea was that that would give in-flight origin PRs presubmit proxy coverage while folks worked on either fixing the tests to work in the proxy case or get proxy skips baked into origin instead of grafted on via TEST_SKIPS. I think that still makes sense. The reason this is an issue is because our branch-forking process dropped the optional: true bit; more context on that in #19716 (which is restoring optional: true for 4.8 origin proxy presubmits, among other things).

[openshift-ci]

@vrutkovs: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/rehearse/openshift/origin/master/e2e-aws-proxy	bd8d147	link	/test pj-rehearse
ci/rehearse/openshift/origin/release-4.8/e2e-aws-proxy	bd8d147	link	/test pj-rehearse
ci/rehearse/openshift/origin/release-4.9/e2e-aws-proxy	bd8d147	link	/test pj-rehearse
ci/prow/pj-rehearse	bd8d147	link	/test pj-rehearse
ci/rehearse/openshift/origin/release-4.7/e2e-aws-proxy	bd8d147	link	/test pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[wking]

ah, @sgreene570 dropped the LGTM here and #12375 was his too. I still think we want #19716 to be more consistent about whether we consider proxy presubmits to be blocking for origin PRs, but I'll defer to Steve on how to handle TEST_SKIPS until NE-534 gets worked out.

/hold cancel

[bparees]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, sgreene570, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• ci-operator/config/openshift/origin/OWNERS [bparees]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-ci]

@vrutkovs: Updated the following 4 configmaps:

• ci-operator-4.7-configs configmap in namespace ci at cluster app.ci using the following files:
  • key openshift-origin-release-4.7.yaml using file ci-operator/config/openshift/origin/openshift-origin-release-4.7.yaml
• ci-operator-4.8-configs configmap in namespace ci at cluster app.ci using the following files:
  • key openshift-origin-release-4.8.yaml using file ci-operator/config/openshift/origin/openshift-origin-release-4.8.yaml
• ci-operator-4.9-configs configmap in namespace ci at cluster app.ci using the following files:
  • key openshift-origin-release-4.9.yaml using file ci-operator/config/openshift/origin/openshift-origin-release-4.9.yaml
• ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
  • key openshift-origin-master.yaml using file ci-operator/config/openshift/origin/openshift-origin-master.yaml

Details

In response to this:

Several router tests are permafailing, and per https://bugzilla.redhat.com/show_bug.cgi?id=1882486 these are expected to be skipped.

The workflow was updated to set TEST_SKIPS, but origin test definition resets to empty skip list.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.