openshift-e2e-test: Error if no TEST_SKIPS match#20619
Merged
openshift-ci[bot] merged 1 commit intoopenshift:masterfrom Aug 3, 2021
Merged
openshift-e2e-test: Error if no TEST_SKIPS match#20619openshift-ci[bot] merged 1 commit intoopenshift:masterfrom
openshift-ci[bot] merged 1 commit intoopenshift:masterfrom
Conversation
Member
Author
|
/cc @EmilienM |
pierreprinetti
force-pushed
the
explicit_test_skips_error
branch
from
ba99e63 to
5fb0d10
Compare
Member
|
/lgtm |
Member
Author
|
/cc vrutkovs |
vrutkovs
suggested changes
Aug 3, 2021
Contributor
There was a problem hiding this comment.
/bin/bash: -c: line 221: syntax error near unexpected token `fi'
in all jobs
Member
Author
There was a problem hiding this comment.
oh no :(
I have added the missing semicolon and the tests now look better.
Thanks for the /approve!
This change prints an error message to STDOUT when the passed environment variable TEST_SKIPS does not match any test. Previously, the call to `grep` would just fail and the container would fail after printing "Skipping tests:".
pierreprinetti
force-pushed
the
explicit_test_skips_error
branch
from
5fb0d10 to
f2070ae
Compare
vrutkovs
approved these changes
Aug 3, 2021
Contributor
vrutkovs
left a comment
vrutkovs
left a comment
There was a problem hiding this comment.
Skipping tests:
"[sig-cli] Kubectl Port forwarding With a server listening on 0.0.0.0 should support forwarding over websockets [Suite:openshift/conformance/parallel] [Suite:k8s]"
"[sig-cli] Kubectl Port forwarding With a server listening on localhost should support forwarding over websockets [Suite:openshift/conformance/parallel] [Suite:k8s]"
"[sig-cli] Kubectl client Simple pod should support exec through an HTTP proxy [Suite:openshift/conformance/parallel] [Suite:k8s]"
"[sig-cli] Kubectl client Simple pod should support exec through kubectl proxy [Suite:openshift/conformance/parallel] [Suite:k8s]"
in ci/rehearse/openshift/installer/release-4.9/e2e-openstack-byon log, no weird failures
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: EmilienM, pierreprinetti, vrutkovs The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Contributor
|
@pierreprinetti: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Contributor
|
@pierreprinetti: Updated the
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change prints an error message to STDOUT when the passed
environment variable TEST_SKIPS does not match any test.
Previously, the call to
grepwould just fail and the container wouldfail after printing "Skipping tests:".