Skip to content

core-services: Add plank config for ARM64 clusters#20811

Merged
openshift-ci[bot] merged 1 commit intoopenshift:masterfrom
LorbusChris:arm-config
Aug 3, 2021
Merged

core-services: Add plank config for ARM64 clusters#20811
openshift-ci[bot] merged 1 commit intoopenshift:masterfrom
LorbusChris:arm-config

Conversation

@LorbusChris
Copy link
Copy Markdown
Contributor

@LorbusChris LorbusChris commented Aug 2, 2021

This commit switches the plank config from using
default_decoration_configs to default_decoration_config_entries,
and adds ARM64 utility_images instead of the x86 ones usually used to
the arm01 build farm.


Note: The config updater might have to be changed so it can update the new arm64 utility image refs.

@LorbusChris
Copy link
Copy Markdown
Contributor Author

/cc @stevekuznetsov
/cc @alvaroaleman
/cc @hongkailiu

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure this supports regex?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, at least that's what the README says: https://github.com/kubernetes/test-infra/tree/master/prow/plank

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've changed the cluster value to hardcode arm01 for now, and also opened kubernetes/test-infra#23096

@LorbusChris LorbusChris force-pushed the arm-config branch 2 times, most recently from 82c1c6d to aa211c8 Compare August 2, 2021 19:14
@LorbusChris
Copy link
Copy Markdown
Contributor Author

Could anybody comment on whether the bot's automatic image ref updates would be broken by this? If so, please let me know where that code lives so I can take a look :)

@alvaroaleman
Copy link
Copy Markdown
Contributor

Could anybody comment on whether the bot's automatic image ref updates would be broken by this? If so, please let me know where that code lives so I can take a look :)

It shouldn't, afaik it just does string replacements.

Is it possible to have one decoration config for the images that gets merged into all the other ones? What we have currently is annoying to read because it makes one think the config had different values there

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 3, 2021
This commit switches the plank config from using
`default_decoration_configs` to `default_decoration_config_entries`,
and adds ARM64 `utility_images` instead of the x86 ones usually used to
the `arm01` build farm.
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 3, 2021
@LorbusChris
Copy link
Copy Markdown
Contributor Author

@alvaroaleman do you mean one decoration config containing only the utility_images that gets merged into all configs except on the arm cluster? I don't know if that's supported - I guess it is but I'd rather do such optimizations later.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 3, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Aug 3, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, LorbusChris

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 3, 2021
@openshift-ci openshift-ci bot merged commit ee576ed into openshift:master Aug 3, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Aug 3, 2021

@LorbusChris: Updated the config configmap in namespace ci at cluster app.ci using the following files:

  • key config.yaml using file core-services/prow/02_config/_config.yaml
Details

In response to this:

This commit switches the plank config from using
default_decoration_configs to default_decoration_config_entries,
and adds ARM64 utility_images instead of the x86 ones usually used to
the arm01 build farm.


Note: The config updater might have to be changed so it can update the new arm64 utility image refs.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants