core-services: Add plank config for ARM64 clusters#20811
core-services: Add plank config for ARM64 clusters#20811openshift-ci[bot] merged 1 commit intoopenshift:masterfrom
Conversation
|
/cc @stevekuznetsov |
There was a problem hiding this comment.
Are you sure this supports regex?
There was a problem hiding this comment.
yes, at least that's what the README says: https://github.com/kubernetes/test-infra/tree/master/prow/plank
There was a problem hiding this comment.
There was a problem hiding this comment.
I've changed the cluster value to hardcode arm01 for now, and also opened kubernetes/test-infra#23096
82c1c6d to
aa211c8
Compare
|
Could anybody comment on whether the bot's automatic image ref updates would be broken by this? If so, please let me know where that code lives so I can take a look :) |
It shouldn't, afaik it just does string replacements. Is it possible to have one decoration config for the images that gets merged into all the other ones? What we have currently is annoying to read because it makes one think the config had different values there |
This commit switches the plank config from using `default_decoration_configs` to `default_decoration_config_entries`, and adds ARM64 `utility_images` instead of the x86 ones usually used to the `arm01` build farm.
|
@alvaroaleman do you mean one decoration config containing only the utility_images that gets merged into all configs except on the arm cluster? I don't know if that's supported - I guess it is but I'd rather do such optimizations later. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, LorbusChris The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@LorbusChris: Updated the
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This commit switches the plank config from using
default_decoration_configstodefault_decoration_config_entries,and adds ARM64
utility_imagesinstead of the x86 ones usually used tothe
arm01build farm.Note: The config updater might have to be changed so it can update the new arm64 utility image refs.