cluster-capi-operator: setup ci jobs #22180
Conversation
There was a problem hiding this comment.
You don't need to specify the exact main file, the package will suffice and from what we've seen, causes fewer issues
| binary_build_commands: go build -o bin/meta-cluster-api-operator cmd/meta-cluster-api-operator/main.go | |
| binary_build_commands: go build -o bin/meta-cluster-api-operator cmd/meta-cluster-api-operator/ |
alexander-demicev
force-pushed
the
metacapi
branch
2 times, most recently
from
edf3d30 to
b7598f1
Compare
|
/retest |
|
/assign @smarterclayton @smarterclayton I added a new component that we are planning to release in 4.10 https://github.com/openshift/meta-cluster-api-operator |
There was a problem hiding this comment.
Naming review:
Ok, why is this called "meta"? From a naming perpective I don't understand what "meta" means, so if you can articulate that it'll help me review.
There was a problem hiding this comment.
openshift/enhancements#913 - enhancement that describes what this component does
alexander-demicev
changed the title
alexander-demicev
force-pushed
the
metacapi
branch
from
b7598f1 to
2f95e41
Compare
openshift-ci
bot
added
the
needs-rebase
alexander-demicev
force-pushed
the
metacapi
branch
from
2f95e41 to
7fdc78b
Compare
openshift-ci
bot
removed
the
needs-rebase
alexander-demicev
force-pushed
the
metacapi
branch
3 times, most recently
from
b7b8529 to
a9b8051
Compare
alexander-demicev
force-pushed
the
metacapi
branch
from
a9b8051 to
ac4976d
Compare
|
@alexander-demichev: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
alexander-demicev
changed the title
|
/approve naming |
openshift-ci
bot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexander-demichev, JoelSpeed, smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@alexander-demichev: Updated the following 6 configmaps:
DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| registry.ci.openshift.org/origin/4.10:cluster-bootstrap quay.io/openshift/origin-cluster-bootstrap:4.10 quay.io/openshift/origin-cluster-bootstrap:4.10.0 quay.io/openshift/origin-cluster-bootstrap:latest | ||
| registry.ci.openshift.org/origin/4.10:cluster-capacity quay.io/openshift/origin-cluster-capacity:4.10 quay.io/openshift/origin-cluster-capacity:4.10.0 quay.io/openshift/origin-cluster-capacity:latest | ||
| registry.ci.openshift.org/origin/4.10:cluster-capi-operator quay.io/openshift/origin-cluster-capi-operator:4.10 quay.io/openshift/origin-cluster-capi-operator:4.10.0 quay.io/openshift/origin-cluster-capi-operator:latest | ||
| registry.ci.openshift.org/origin/4.10:cluster-capi-operator-src quay.io/openshift/origin-cluster-capi-operator-src:4.10 quay.io/openshift/origin-cluster-capi-operator-src:4.10.0 quay.io/openshift/origin-cluster-capi-operator-src:latest |
There was a problem hiding this comment.
i missed this during review, why are we publishing a source image like this? what does it enable?
There was a problem hiding this comment.
There is an enhancement that describes what it does https://github.com/openshift/enhancements/pull/913/files#diff-a0672895c853aefb4deaafb651c091b4e24d5dc2648e340e8e85deb4de58e564R100
…-operator-src We've been building it since ac4976d (cluster-capi-operator: setup ci jobs, 2021-09-22, openshift#22180), and because of the generous 'promotion' block, we've been pushing it into the CI ImageStream, where it's feeding release images: $ oc adm release info --commits registry.ci.openshift.org/ocp/release:4.10.0-0.ci-2021-11-05-164015 | grep capi-operator cluster-capi-operator https://github.com/openshift/cluster-capi-operator e592380e9137abf1ad5cee475645f5d33848e7a3 cluster-capi-operator-src https://github.com/openshift/cluster-capi-operator e592380e9137abf1ad5cee475645f5d33848e7a3 and creating redundant manifests: $ oc adm release extract --to manifests registry.ci.openshift.org/ocp/release:4.10.0-0.ci-2021-11-05-164015 Extracted release payload from digest sha256:0e36c656e499209e018315b86f542cc6714ebb2952f9306860158854440dfb22 created at 2021-11-05T16:40:37Z $ grep -r 'name: cluster-api' manifests manifests/0000_30_capi-operator_12_clusteroperator_2.yaml: name: cluster-api manifests/0000_30_capi-operator_12_clusteroperator_2.yaml: name: cluster-api manifests/0000_30_capi-operator_12_clusteroperator.yaml: name: cluster-api manifests/0000_30_capi-operator_12_clusteroperator.yaml: name: cluster-api All of the actual tests consume the local, default 'src' image, so removing this image shouldn't break anything, and will allow us to remove the published tag and clean the 4.10 CI releases back up.
4 participants
No description provided.