psap/sro: Fix incorrectly promoted test-bin image - #25922
Conversation
|
I think @enriquebelarte has been working on this lately. |
c997389 to
9ad0eac
Compare
All items from `images:` are promoted by default under their normal names. This config used to build a `test-bin` image (which is a poor name for a promoted image) and promoted it under both original `test-bin` and additional `sro-test-bin` name. Because these images are promoted to `ocp` namespace, they end up being mirrored on Quay. Hence, rename the `test-bin` image to `sro-test-bin` and let it be normally promoted under this name. Not promoting `test-bin` anymore will remove it from the mirroring lists for OpenShift.
9ad0eac to
001ebee
Compare
|
@petr-muller: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Thanks for the PR @petr-muller. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: petr-muller, ybettan The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/assign @bparees |
|
are we confident there are no references/consumers of the test-bin pullspec? also, though it's clearly too late at this point, if "sro-test-bin" were being submitted as an image name today, i don't think it would be accepted as it i think it falls short on the "only use well known/community understood acronyms" rule. |
It was created yesterday by @enriquebelarte so we can reuse that image d/s instead of replicating the image definition so I don't see any reason some else is using that image since yesterday - also it have a very specific use that I don't think anyone else will benefit from.
Should we consider another name then? do you have any consideration or some reference explaining what a good name will be? |
@petr-muller it looks like this image came in with 0bf8e47#diff-be305e611568a440e14617e653508f270434bdadd931d7971affca11fe3bce8eR247 which i approved, but i was not expecting that PR to include net new images that didn't exist in 4.10. I assumed it was just carrying forward 4.10 images. Was my expectation incorrect? I did not audit every single image in that 4.11 file because i assumed they were all pre-existing 4.10 names.
guidelines are here: i suggest "origin-special-resources-operator-test-bin", you're already using "origin-special-resource-operator" |
|
@bparees it was a race in the process. These images were added to master configs after we branched to 4.11 but before we The problem is that a PR to introduce 4.11 mirroring lists was supposed to be created much sooner (reading the process doc, it was supposed to happen after 4.9 code freeze - after 4.11 config was bootstrapped in #23900), but I missed it. Minor issues like this will likely happen until we have time to improve the branching automation. |
was test-bin/sro-test-bin the only image that slipped through? |
|
@ybettan @enriquebelarte Should forget about promoting this image at all, and build it like we do upstream? We will anyway remove it in a matter of weeks, and it would probably simplify the current situation. |
|
Yea probably, it will be simpler indeed @qbarrand |
|
OK, so I suggest we:
@petr-muller Will we have some potential issues revering #25426 regarding the fact we are going to remove already promoted images? FYI @enriquebelarte |
No unless something consumes them. Once you stop promoting it, it will eventually be GC'd from the promotion destination. |
|
We are reverting the image promotion so I guess we can close that PR @petr-muller #26026 |
|
/uncc |
|
LOL /close |
|
@petr-muller: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
4 participants
All items from
images:are promoted by default under their normal names. This config used to build atest-binimage (which is a poor name for a promoted image) and promoted it under both originaltest-binand additionalsro-test-binname. Because these images are promoted toocpnamespace, they end up being mirrored on Quay.Hence, rename the
test-binimage tosro-test-binand let it be normally promoted under this name. Not promotingtest-binanymore will remove it from the mirroring lists for OpenShift.