Skip to content

Rename configmap-reload output image to configmap-reloader#2603

Merged
openshift-merge-robot merged 1 commit into
openshift:masterfrom
smarterclayton:rename_configmap_reload
Jan 15, 2019
Merged

Rename configmap-reload output image to configmap-reloader#2603
openshift-merge-robot merged 1 commit into
openshift:masterfrom
smarterclayton:rename_configmap_reload

Conversation

@smarterclayton

Copy link
Copy Markdown
Contributor

This makes the name consistent with the OCP name, and also the name that
is being used on dockerhub.

This makes the name consistent with the OCP name, and also the name that
is being used on dockerhub.
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 15, 2019
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 15, 2019
@smarterclayton

Copy link
Copy Markdown
Contributor Author

@brancz FYI this brings you more consistent with general use (configmap-reloader works better), I'll handle updating everything.

@smarterclayton smarterclayton added the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2019
@openshift-merge-robot openshift-merge-robot merged commit 6f6461e into openshift:master Jan 15, 2019
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@smarterclayton: Updated the following 2 configmaps:

  • ci-operator-configs configmap using the following files:
    • key openshift-configmap-reload-master.yaml using file ci-operator/config/openshift/configmap-reload/openshift-configmap-reload-master.yaml
  • ci-operator-configs configmap in namespace ci-stg using the following files:
    • key openshift-configmap-reload-master.yaml using file ci-operator/config/openshift/configmap-reload/openshift-configmap-reload-master.yaml
Details

In response to this:

This makes the name consistent with the OCP name, and also the name that
is being used on dockerhub.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants