Run command tests instead of integration for quota sizing - #312
Merged
Conversation
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
openshift-ci-robot
added
the
size/XS
Contributor
|
/lgtm |
Contributor
|
@stevekuznetsov: I updated Prow config for you! DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
derekhiggins
pushed a commit
to derekhiggins/release
that referenced
this pull request
Oct 24, 2023
Run fix_certs script automatically
openshift-merge-bot Bot
pushed a commit
that referenced
this pull request
Aug 7, 2026
* Onboard Azure/ARO-Tools verify job to Prow (AROSLSRE-780) Add a ci-operator presubmit that runs the same verify steps as the repo's native GitHub Actions verify workflow (make tidy/lint/test), matching the pattern used for Azure/ARO-HCP's ci/prow/verify check. This lets the verify check run on OpenShift CI/Prow's own build capacity instead of shared GitHub Actions runners, avoiding the org-wide GitHub Actions capacity backlogs that stalled ARO-Tools PRs in the past (e.g. #312). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix(ARO-Tools verify): fail fast on any command error Add 'set -euo pipefail' to the top of the verify test's commands script, per CodeRabbit review on PR #83080. Without it, a failure in an earlier command (e.g. dnf install or make tidy) would be masked and the script would keep running, silently accepting an inconsistent state before the explicit git-status check. * fix(ARO-Tools verify): add OWNERS files, fix invalid build_root tag - Add config/jobs OWNERS files for Azure/ARO-Tools (filtered to openshift org members, per the ci-operator-owners check), matching the pattern used for Azure/ARO-HCP and Azure/ARO-RP. - Switch build_root image_stream_tag from rhel-9-release-golang-1.25-openshift-4.20 (not present in the quay image stream, rehearsal failed to import it) to -4.22, which every recently-added config on this base image uses, including the sibling Azure/ARO-RP config. * fix(ARO-Tools verify): re-sanitize generated presubmit job Run 'make sanitize-prow-jobs' to add the missing 'cluster: build01' field, which the ordered-prow-config check requires and which my earlier ci-operator-prowgen run (against a slightly stale base) had omitted. * fix(ARO-Tools verify): install graphviz/jq via binary_build_commands The verify test's commands run as a non-root user, so 'dnf install' in the test step's commands (as originally written) fails with 'Permission denied' / 'must be run with superuser privileges', per the rehearsal failure. binary_build_commands runs during the src image build, which has root, so move the package install there and leave the test's commands to just run make tidy/lint/test. * fix(ARO-Tools verify): set HOME=/tmp so golangci-lint can write its cache The test container's default HOME (/) isn't writable by the non-root test user, so golangci-lint failed with 'mkdir /.cache: permission denied' during 'make lint' in the rehearsal run. Exporting HOME=/tmp matches the pattern used by other configs (e.g. identitatem/*) that run tools needing a writable cache dir. * fix(ARO-Tools verify): unset GOFLAGS so go mod tidy/build don't force vendor mode The build_root golang image apparently defaults GOFLAGS to -mod=vendor, but ARO-Tools has no committed vendor directory - go reported 'inconsistent vendoring' for every dependency and golangci-lint failed to even load packages. Unset GOFLAGS before running make tidy/lint/test so go resolves modules normally against go.work/go.sum instead. * fix(ARO-Tools verify): install graphviz/jq as test-only deps, use test-bin container The rehearsal got through tidy/lint/test but two pipelines/graph tests failed - 'dot: executable file not found in $PATH' - because binary_build_commands only affects the promoted 'bin' image, while the verify test ran against 'src'. Since graphviz/jq are only needed to run tests (not to build/promote binaries), use test_binary_build_commands instead and point the test container at test-bin, following the openshift-eng/ofcir pattern. --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Steve Kuznetsov skuznets@redhat.com
/cc @csrwng