Adding build support for archs other than amd64

[Pensu]

This PR removed hardcoded amd64 and allows the golang images to be built for the architecture where the build is running.

[openshift-ci-robot]

Hi @Pensu. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Pensu]

Hi @smarterclayton @stevekuznetsov, can you please review this?

[mkumatag]

In line no. 44 also we need to remove reference for amd64 for dep command download

[Pensu]

Updated.

[stevekuznetsov]

Do subshells work in a RUN? I think I might prefer to see a variable here like $VERSION for $ARCH

[Pensu]

@stevekuznetsov Yeah, subshells work in RUN. (Ref: https://github.com/docker-library/golang/blob/caca81426c40bd592bcfcde80485af80faedeb31/1.12/buster/Dockerfile#L17) However, I have updated the PR to store arch value in $ARCH variable and then use it for curl. Please let me know if that works. Will update other Dockerfiles as well. Thanks.

[stevekuznetsov]

/ok-to-test

We should merge this when we've got someone around to revert it in case something is wrong, as it's a broad change that's hard to test.

[Pensu]

Thanks @stevekuznetsov. Is there anyone whom we can talk to get this merged?

[stevekuznetsov]

Right now my team is in a face-to-face all week so I don't have the bandwidth to monitor if things go wrong after the merge -- @smarterclayton could you? Otherwise we should do it next week when I can.

[smarterclayton]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Pensu, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [smarterclayton]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment