pin golangci-lint to v1.63.4

[tthvo]

Pin CI golangci-lint to v1.63.4 on main. Using latest might bump version and introduce breaking changes.

The latest at the moment is v1.63.4 (sorry, there was a typo when I said v1.64.3).

[tthvo]

/cc @patrickdillon

[openshift-ci-robot]

[REHEARSALNOTIFIER]
@tthvo: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-openshift-installer-main-altinfra-e2e-aws-custom-security-groups	openshift/installer	presubmit	Ci-operator config changed
pull-ci-openshift-installer-main-altinfra-e2e-aws-ovn	openshift/installer	presubmit	Ci-operator config changed
pull-ci-openshift-installer-main-altinfra-e2e-aws-ovn-fips	openshift/installer	presubmit	Ci-operator config changed
pull-ci-openshift-installer-main-altinfra-e2e-aws-ovn-imdsv2	openshift/installer	presubmit	Ci-operator config changed
pull-ci-openshift-installer-main-altinfra-e2e-aws-ovn-localzones	openshift/installer	presubmit	Ci-operator config changed
pull-ci-openshift-installer-main-altinfra-e2e-aws-ovn-proxy	openshift/installer	presubmit	Ci-operator config changed
pull-ci-openshift-installer-main-altinfra-e2e-aws-ovn-shared-vpc	openshift/installer	presubmit	Ci-operator config changed
pull-ci-openshift-installer-main-altinfra-e2e-aws-ovn-shared-vpc-local-zones	openshift/installer	presubmit	Ci-operator config changed
pull-ci-openshift-installer-main-altinfra-e2e-aws-ovn-shared-vpc-wavelength-zones	openshift/installer	presubmit	Ci-operator config changed
pull-ci-openshift-installer-main-altinfra-e2e-aws-ovn-single-node	openshift/installer	presubmit	Ci-operator config changed
pull-ci-openshift-installer-main-altinfra-e2e-aws-ovn-wavelengthzones	openshift/installer	presubmit	Ci-operator config changed
pull-ci-openshift-installer-main-altinfra-e2e-azure-capi-ovn	openshift/installer	presubmit	Ci-operator config changed
pull-ci-openshift-installer-main-altinfra-e2e-azure-ovn-shared-vpc	openshift/installer	presubmit	Ci-operator config changed
pull-ci-openshift-installer-main-altinfra-e2e-gcp-capi-ovn	openshift/installer	presubmit	Ci-operator config changed
pull-ci-openshift-installer-main-altinfra-e2e-gcp-ovn-byo-network-capi	openshift/installer	presubmit	Ci-operator config changed
pull-ci-openshift-installer-main-altinfra-e2e-gcp-ovn-secureboot-capi	openshift/installer	presubmit	Ci-operator config changed
pull-ci-openshift-installer-main-altinfra-e2e-gcp-ovn-xpn-capi	openshift/installer	presubmit	Ci-operator config changed
pull-ci-openshift-installer-main-altinfra-e2e-ibmcloud-capi-ovn	openshift/installer	presubmit	Ci-operator config changed
pull-ci-openshift-installer-main-altinfra-e2e-nutanix-capi-ovn	openshift/installer	presubmit	Ci-operator config changed
pull-ci-openshift-installer-main-altinfra-e2e-openstack-capi-ccpmso	openshift/installer	presubmit	Ci-operator config changed
pull-ci-openshift-installer-main-altinfra-e2e-openstack-capi-ccpmso-zone	openshift/installer	presubmit	Ci-operator config changed
pull-ci-openshift-installer-main-altinfra-e2e-openstack-capi-dualstack	openshift/installer	presubmit	Ci-operator config changed
pull-ci-openshift-installer-main-altinfra-e2e-openstack-capi-dualstack-upi	openshift/installer	presubmit	Ci-operator config changed
pull-ci-openshift-installer-main-altinfra-e2e-openstack-capi-dualstack-v6primary	openshift/installer	presubmit	Ci-operator config changed
pull-ci-openshift-installer-main-altinfra-e2e-openstack-capi-externallb	openshift/installer	presubmit	Ci-operator config changed

A total of 132 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[tthvo]

/pj-rehearse pull-ci-openshift-installer-main-golint

[openshift-ci-robot]

@tthvo: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[tthvo]

Hm, it looks like v1.63.4 tag is not available but latest does point to it. I do need to change the mirror configuration:

release/core-services/image-mirroring/_config.yaml

Line 746 in 03ce601

ci/golangci-lint:latest:

@patrickdillon Is it okay to do so?

[patrickdillon]

Hm, it looks like v1.63.4 tag is not available but latest does point to it. I do need to change the mirror configuration:

release/core-services/image-mirroring/_config.yaml

Line 746 in 03ce601

ci/golangci-lint:latest:

@patrickdillon Is it okay to do so?

Oh, I see, the latest tag is a literal tag on the mirrored image... it doesn't select the latest version 🤦 We can't change the latest tag, but you could potentially add a tag for v1.63.4 pointing to the same image

[tthvo]

Oh, I see, the latest tag is a literal tag on the mirrored image... it doesn't select the latest version 🤦 We can't change the latest tag, but you could potentially add a tag for v1.63.4 pointing to the same image

Sounds good! I separate the patch to another PR: #61018

[patrickdillon]

/pj-rehearse pull-ci-openshift-installer-main-golint

[openshift-ci-robot]

@patrickdillon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[patrickdillon]

/approve
/lgtm

waiting on rehearsal

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon, tthvo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• ci-operator/config/openshift/installer/OWNERS [patrickdillon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@tthvo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/rehearse/openshift/installer/main/golint	c96bda7	link	unknown	/pj-rehearse pull-ci-openshift-installer-main-golint

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[patrickdillon]

/pj-rehearse ack

[openshift-ci-robot]

@patrickdillon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.