Skip to content

mirror: create v1.63.4 tag for golangci-lint#61018

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
tthvo:golangci-lint-tag-v1.63.4
Jan 28, 2025
Merged

mirror: create v1.63.4 tag for golangci-lint#61018
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
tthvo:golangci-lint-tag-v1.63.4

Conversation

@tthvo
Copy link
Copy Markdown
Member

@tthvo tthvo commented Jan 27, 2025

Create a tag v1.63.4 to point to golangci-lint v1.63.4 (latest). This allows other to pin version of the tool.

@tthvo tthvo mentioned this pull request Jan 27, 2025
Merged
@openshift-ci openshift-ci Bot requested review from jmguzik and smg247 January 27, 2025 19:20
@tthvo
Copy link
Copy Markdown
Member Author

tthvo commented Jan 27, 2025

/cc @patrickdillon

@openshift-ci openshift-ci Bot requested a review from patrickdillon January 27, 2025 19:20
@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jan 27, 2025
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Jan 27, 2025

[REHEARSALNOTIFIER]
@tthvo: no rehearsable tests are affected by this change

@patrickdillon
Copy link
Copy Markdown
Contributor

patrickdillon commented Jan 27, 2025

/lgtm

We will need approval from the test platform @danilo-gemoli PTAL

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jan 27, 2025
@danilo-gemoli
Copy link
Copy Markdown
Contributor

danilo-gemoli commented Jan 28, 2025

/lgtm

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danilo-gemoli, patrickdillon, tthvo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 28, 2025
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 28, 2025

@tthvo: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit 8c76a52 into openshift:master Jan 28, 2025
@tthvo tthvo deleted the golangci-lint-tag-v1.63.4 branch January 28, 2025 16:06
fjglira pushed a commit to fjglira/release that referenced this pull request Feb 5, 2025
@tthvo @fjglira
mirror: create v1.63.4 tag for golangci-lint (openshift#61018)
5eb8106
jtaleric pushed a commit to jtaleric/release that referenced this pull request Feb 10, 2025
@tthvo @jtaleric
mirror: create v1.63.4 tag for golangci-lint (openshift#61018)
6bca588
@tthvo tthvo mentioned this pull request Dec 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmguzik jmguzik Awaiting requested review from jmguzik

@smg247 smg247 Awaiting requested review from smg247

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

Assignees

@patrickdillon patrickdillon

@danilo-gemoli danilo-gemoli

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tthvo @openshift-ci-robot @patrickdillon @danilo-gemoli